Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag for maintainer and first time contributors #36

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

samuelmaddock
Copy link
Member

Adds tags to indicate whether a PR is by a maintainer or first time contributor. These are just alias emojis which are customizable in the workspace.

🔰 is a common bumper sticker seen in Japan for beginner drivers, the shoshinsha mark. Open to other ideas here :)

Debating whether or not to keep the maintainer tag and only highlight first time contributors.

Screenshot 2024-08-03 at 11 26 39 AM

@samuelmaddock samuelmaddock requested a review from a team as a code owner August 3, 2024 15:34
@dsanders11
Copy link
Member

Debating whether or not to keep the maintainer tag and only highlight first time contributors.

Personally, I think it looks a bit cluttered with the maintainer tag, given that the majority have it.

Perhaps swap the maintainer tag for an external contributor tag? Then the default (no tag) is maintainer, and a tag represents an external contributor (with a special tag for first time contributors).

@samuelmaddock
Copy link
Member Author

@dsanders11 agreed and sounds good! And I think highlighting outside contributions should be the case.

Screenshot 2024-08-03 at 2 36 08 PM

@samuelmaddock samuelmaddock merged commit 59bdffd into electron:main Aug 8, 2024
3 checks passed
@samuelmaddock samuelmaddock deleted the feat/first-time-contrib branch August 8, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants