Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: silence slack messages during quiet period #17

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Dec 4, 2023

Doesn't post to Slack during December.

For individual label additions, I think this change depends on Octokit's pull_request.updated_at prop to also reflect the latest time a label was added, since webhook payloads don't seem to come with a timestamp. (Alternatively, we could check the default new Date() constructor call similar to how it's done for the reminders.) This now uses new Date() for everything.

@erickzhao erickzhao requested a review from a team as a code owner December 4, 2023 23:25
@samuelmaddock
Copy link
Member

This is the message for newly posted APIs, right? I'd personally like to still see the messages since they only get posted when they're initially created.

I think a compromise could be:

  • Don't @ the wg-api team during December
  • Disable the reminder listing all open PRs during December

src/remind.ts Outdated Show resolved Hide resolved
@erickzhao
Copy link
Member Author

This is the message for newly posted APIs, right? I'd personally like to still see the messages since they only get posted when they're initially created.

@samuelmaddock Currently it's both of them! I can disable the ping only as a compromise and keep new PR messages coming in :)

@erickzhao erickzhao merged commit 1ccd5db into main Dec 5, 2023
3 checks passed
@erickzhao erickzhao deleted the silent-night branch December 5, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants