Fix inline code baseline alignment issue #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
requested changes
Mar 3, 2025
There was a problem hiding this comment.
I checked out this PR, and it seems like the problem is actually worse, at least on Chrome?
| electronjs.org | This PR |
|---|---|
 |
 |
Also, the unrelated changes added along with the added comments (and the one we had that was removed!) makes it seem to me like this PR is copy/pasted from ChatGPT. Please don't do this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes the inline code baseline alignment issue on the Electron documentation website. The issue causes inline code snippets (
elements) to appear misaligned (too low) in Firefox 134.0.2 on macOS 15.Closes #749