-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wg-ecosystem): add Node version policy and cleanup #578
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,19 +6,19 @@ Oversees the projects that make Electron app development easier. | |
|
||
| Avatar | Name | Role | Time Zone | | ||
| -------------------------------------------|----------------------|----------------------------| -------- | | ||
| <img src="https://github.com/blackhole1.png" width=100 alt="@blackhole1"> | Black-Hole [@blackhole1](https://github.com/blackhole1) | Member | BJT (Hangzhou) | | ||
| <img src="https://github.com/caoxiemeihao.png" width=100 alt="@caoxiemeihao"> | caoxiemeihao [@caoxiemeihao](https://github.com/caoxiemeihao) | Member | BJT (Hangzhou) | | ||
| <img src="https://github.com/ckerr.png" width=100 alt="@ckerr"> | Charles Kerr [@ckerr](https://github.com/ckerr) | Member | CT (New Orleans) | | ||
| <img src="https://github.com/dsanders11.png" width=100 alt="@dsanders11"> | David Sanders [@dsanders11](https://github.com/dsanders11) | Member | PT (Santa Barbara) | | ||
| <img src="https://github.com/erickzhao.png" width=100 alt="@erickzhao"> | Erick Zhao [@erickzhao](https://github.com/erickzhao) | Member | PT (Vancouver) | | ||
| <img src="https://github.com/erikian.png" width=100 alt="@erikian"> | Erik Moura [@erikian](https://github.com/erikian) | Member | BRT (Francisco Beltrão) | | ||
| <img src="https://github.com/felixrieseberg.png" width=100 alt="@felixrieseberg"> | Felix Rieseberg [@felixrieseberg](https://github.com/felixrieseberg) | Member | PT (San Francisco) | | ||
| <img src="https://github.com/georgexu99.png" width=100 alt="@georgexu99"> | George Xu [@georgexu99](https://github.com/georgexu99) | Member | PT (San Francisco) | | ||
| <img src="https://github.com/kilian.png" width=100 alt="@kilian"> | Kilian Valkhof [@kilian](https://github.com/kilian) | Member | CET (Netherlands) | | ||
| <img src="https://github.com/malept.png" width=100 alt="@malept"> | Mark Lee [@malept](https://github.com/malept) | Member | PT (Seattle) | | ||
| <img src="https://github.com/marshallofsound.png" width=100 alt="@marshallofsound"> | Samuel Attard [@MarshallOfSound](https://github.com/marshallofsound) | Member | PT (Vancouver) | | ||
| <img src="https://github.com/Toinane.png" width=100 alt="@Toinane"> | Toinane [@toinane](https://github.com/toinane) | Member | CET (France) | | ||
| <img src="https://github.com/VerteDinde.png" width=100 alt="@VerteDinde"> | Keeley Hammond [@VerteDinde](https://github.com/VerteDinde) | Member | PT (Portland) | | ||
| <img src="https://github.com/blackhole1.png" width=100 alt="@blackhole1"> | Black-Hole [@blackhole1](https://github.com/blackhole1) | Member | BJT (Hangzhou) | | ||
| <img src="https://github.com/georgexu99.png" width=100 alt="@georgexu99"> | George Xu [@georgexu99](https://github.com/georgexu99) | Member | PT (San Francisco) | | ||
| <img src="https://github.com/caoxiemeihao.png" width=100 alt="@caoxiemeihao"> | caoxiemeihao [@caoxiemeihao](https://github.com/caoxiemeihao) | Member | BJT (Hangzhou) | | ||
| <img src="https://github.com/erikian.png" width=100 alt="@erikian"> | Erik Moura [@erikian](https://github.com/erikian) | Member | BRT (Francisco Beltrão) | | ||
| <img src="https://github.com/yangannyx.png" width=100 alt="@yangannyx"> | Anny Yang [@yangannyx](https://github.com/yangannyx) | Member | PST (San Francisco) | | ||
|
||
## Emeritus Members | ||
|
@@ -43,7 +43,7 @@ These projects are sorted alphabetically, their order does not reflect that any | |
|
||
* Documentation across all `electron/*` repositories, primarily focusing on `electron/electron/docs` in the repo and the website | ||
* Implementation and design of the Electron website | ||
* Management of Heroku apps for the site and [associated repositories](#associated-repositories) | ||
* Management of Heroku apps for [our repositories](#associated-repositories) | ||
* Management of the Algolia search tooling | ||
* Management of translations via Crowdin | ||
* Tools (Core) | ||
|
@@ -60,10 +60,7 @@ These projects are sorted alphabetically, their order does not reflect that any | |
* Update server (update.electronjs.org) | ||
* Windows Installer (`electron-winstaller`) | ||
* Tools (Userland) | ||
* Devtron | ||
* electron-compile | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Never 4get There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rip end of an era |
||
* electron-installer-\* | ||
* Spectron | ||
|
||
...and all other third party community based Electron tools. | ||
|
||
|
@@ -84,7 +81,6 @@ These repos are sorted alphabetically, their order does not reflect that any of | |
* [`electron/docs-parser`](https://github.com/electron/docs-parser) | ||
* [`electron/download-stats`](https://github.com/electron/download-stats) | ||
* [`electron/electron-quick-start`](https://github.com/electron/electron-quick-start) | ||
* [`electron/electron-quick-start-typescript`](https://github.com/electron/electron-quick-start-typescript) | ||
* [`electron/fiddle`](https://github.com/electron/fiddle) | ||
* [`electron/forge`](https://github.com/electron/forge) | ||
* [`electron/get`](https://github.com/electron/get) | ||
|
@@ -95,9 +91,9 @@ These repos are sorted alphabetically, their order does not reflect that any of | |
* [`electron/notarize`](https://github.com/electron/notarize) | ||
* [`electron/osx-sign`](https://github.com/electron/osx-sign) | ||
* [`electron/packager`](https://github.com/electron/packager) | ||
* [`electron/rcedit`](https://github.com/electron/rcedit) | ||
* [`electron/rebuild`](https://github.com/electron/rebuild) | ||
* [`electron/remote`](https://github.com/electron/remote) | ||
* [`electron/rcedit`](https://github.com/electron/rcedit) | ||
* [`electron/semantic-release-npm-cfa`](https://github.com/electron/semantic-release-npm-cfa) | ||
* [`electron/symbol-server`](https://github.com/electron/symbol-server) | ||
* [`electron/symbolicate-mac`](https://github.com/electron/symbolicate-mac) | ||
|
@@ -111,7 +107,6 @@ These repos are sorted alphabetically, their order does not reflect that any of | |
|
||
### Electron Userland Organization | ||
|
||
* [`electron-userland/devtron`](https://github.com/electron/devtron) | ||
* [`electron-userland/electron-installer-common`](https://github.com/electron-userland/electron-installer-common) | ||
* [`electron-userland/electron-installer-debian`](https://github.com/electron-userland/electron-installer-debian) | ||
* [`electron-userland/electron-installer-dmg`](https://github.com/electron-userland/electron-installer-dmg) | ||
|
@@ -120,16 +115,29 @@ These repos are sorted alphabetically, their order does not reflect that any of | |
* [`electron-userland/electron-installer-squirrel-windows`](https://github.com/electron-userland/electron-installer-squirrel-windows) | ||
* [`electron-userland/electron-installer-windows`](https://github.com/electron-userland/electron-installer-windows) | ||
* [`electron-userland/electron-installer-zip`](https://github.com/electron-userland/electron-installer-zip) | ||
* [`electron-userland/spectron`](https://github.com/electron/spectron) | ||
|
||
...and all other repositories that the community would consider maintained by Electron. | ||
|
||
## Node.js Upgrade Policy | ||
|
||
As a general rule, npm packages under the purview of the Ecosystem WG will support Node.js versions as | ||
long as possible, even after a version has reached its End-Of-Life (EOL) date. | ||
If too much friction arises from the burden of maintaining EOL versions of Node.js (e.g. trouble upgrading | ||
dependencies or CI issues), we will perform a blanket upgrade of supported Node.js versions for all our packages | ||
to the latest LTS version. This upgrade process will be revisited annually. | ||
|
||
As of July 2024, our current plan is to upgrade all packages to the earliest Node.js version where `require()` | ||
of synchronous ESM graphs will be supported (see [nodejs/node#51977](https://github.com/nodejs/node/pull/51977) and [nodejs/node#53500](https://github.com/nodejs/node/pull/53500)) | ||
some point after that version reaches its LTS date ([see Node.js release schedule for more details](https://nodejs.org/en/about/previous-releases#release-schedule)). | ||
|
||
## Meeting Schedule | ||
|
||
**Sync Meeting** 30min every other Wednesday @ [18:00 UTC](https://duckduckgo.com/?q=18%3A00+UTC&ia=answer) | ||
**Sync Meeting** 1 hour every other Tuesday @ [17:00 UTC](https://duckduckgo.com/?q=17%3A00+UTC&ia=answer) | ||
|
||
Meeting notes may be viewed in [meeting-notes](meeting-notes). | ||
|
||
## Joining the Ecosystem WG | ||
|
||
Prospective new members should reach out to an existing member to ask to be invited to the regular meetings and to be added as a Slack guest to #wg-ecosystem. That person may be added to the working group by a 2/3rds vote of WG members at a WG meeting. The prospective member should leave the meeting while the deliberation & vote is underway, and be informed only of the outcome of the vote (approved/not approved). | ||
Prospective new members should reach out to an existing member to ask to be invited to the regular meetings and to be added as a Slack guest to #wg-ecosystem. | ||
That person may be added to the working group by a 2/3rds vote of WG members at a WG meeting. | ||
The prospective member should leave the meeting while the deliberation & vote is underway, and be informed only of the outcome of the vote (approved/not approved). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing the order here? It was order-joined originally which was kinda nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already alphabetized by GitHub username for everyone else but our most recent members added themselves at the bottom so I kind of fixed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, considering I was second in the list. 😅