fix: actually use the artifactSuffix when generating the filename (#111)

electron · Jul 24, 2019 · 52d9c0e · 52d9c0e
1 parent 7c8b45b
commit 52d9c0e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/artifact-utils.ts b/src/artifact-utils.ts
@@ -27,7 +27,13 @@ export function getArtifactFileName(
 
   ensureIsTruthyString(details, 'platform');
   ensureIsTruthyString(details, 'arch');
-  return `${[details.artifactName, details.version, details.platform, details.arch].join('-')}.zip`;
+  return `${[
+    details.artifactName,
+    details.version,
+    details.platform,
+    details.arch,
+    ...(details.artifactSuffix ? [details.artifactSuffix] : []),
+  ].join('-')}.zip`;
 }
 
 function mirrorVar(name: keyof MirrorOptions, options: MirrorOptions, defaultValue: string) {

diff --git a/test/artifact-utils.spec.ts b/test/artifact-utils.spec.ts
@@ -36,5 +36,18 @@ describe('artifact-utils', () => {
         }),
       ).toMatchInlineSnapshot(`"chromedriver-v1.0.1-android-ia32.zip"`);
     });
+
+    it('should return the correct hypenated artifact names for artifacts with a suffix', () => {
+      expect(
+        getArtifactFileName({
+          isGeneric: false,
+          artifactName: 'electron',
+          version: 'v1.0.1',
+          platform: 'darwin',
+          arch: 'x64',
+          artifactSuffix: 'symbols',
+        }),
+      ).toMatchInlineSnapshot(`"electron-v1.0.1-darwin-x64-symbols.zip"`);
+    });
   });
 });