fix(GotDownloader): destroy the writeStream if possible when the down…

…load errors (#145)
electron · Feb 10, 2020 · 2422ca4 · 2422ca4
1 parent 7b524f5
commit 2422ca4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/GotDownloader.ts b/src/GotDownloader.ts
@@ -15,7 +15,13 @@ export class GotDownloader implements Downloader<any> {
       const downloadStream = got.stream(url, options);
       downloadStream.pipe(writeStream);
 
-      downloadStream.on('error', error => reject(error));
+      downloadStream.on('error', error => {
+        if (writeStream.destroy) {
+          writeStream.destroy(error);
+        }
+
+        reject(error);
+      });
       writeStream.on('error', error => reject(error));
       writeStream.on('close', () => resolve());
     });

diff --git a/test/GotDownloader.network.spec.ts b/test/GotDownloader.network.spec.ts
@@ -22,9 +22,6 @@ describe('GotDownloader', () => {
     });
 
     it('should throw an error if the file does not exist', async function() {
-      if (process.platform === 'win32') {
-        return;
-      }
       const downloader = new GotDownloader();
       await withTempDirectory(async dir => {
         const testFile = path.resolve(dir, 'test.txt');