fix(maker-wix): version with pre-release tag breaks app start

[ShGKme]

Resolves

• Fix: Removal of prerelease tags in normalizeWindowsVersion prevents app installed via MSI installer from starting on Windows #3805

Details

1. @electron-forge/maker-wix replaces the version (semantic version) with the windows compatible, making it an invalid semantic version, e.g. 1.2.3-beta -> 1.2.3.0
2. electron-wix-msi expects a semantic version as an input option and then separates it into 2 versions:
   • semanticVersion - used as an actual app version, e.g. 1.2.3-beta
   • windowsCompliantVersion - used as an .msi version that follows the Windows version format and doesn't support semver, e.g. 1.2.3.0
   • See: https://github.com/electron-userland/electron-wix-msi/blob/3d476237f631380e2252027c4fde20eacccd438e/src/creator.ts#L204-L205
3. StubExecutable expects the app to be in app-{semver} folder and search to the latest semantic version
   • If there is no semantic version - it finds nothing
   • See: https://github.com/bitdisaster/Squirrel.Msi/blob/master/src/StubExecutable/Semver200_parser.cpp
4. Because @electron-forge/maker-wix passes an invalid semantic version as the version StubExecutable cannot run the app

As a result, building with a version with a pre-release tag or build metadata results in an unstartable installation.

Notes

I kept the note. But I think it can be moved to the documentation instead.

[erickzhao]

Needs import semver from 'semver' above but:

Suggested change

	const { version } = packageJSON;
	if (version.includes('-') || version.includes('+')) {
	const { version } = packageJSON;
	const parsed = semver.prerelease(version);
	if (Array.isArray(parsed) && parsed.length > 0) {

[ShGKme]

I'm fine with using semver package to check the version components (I thought about it but didn't want to add it to have one more dependency just to show one log message).

But I intentionally added a new check for + because prerelease is not the only part of semver that will be changed. There is also build part.

[erickzhao]

Ah, thanks! Didn't realize there was that distinction between + and - so I had to re-read the spec.

Since we're already including semver in many places across the monorepo (including @electron-forge/core, I think adding the dep to maker-wix is kind of "free" in a sense!

[ShGKme]

I was just about to push squashed commit ༼ つ ◕_◕ ༽つ

Thanks for a quick review!