perf(cli): minimize resolvePackageManager calls
#3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
changed the title
VerteDinde
approved these changes
Feb 14, 2025
dsanders11
approved these changes
Feb 14, 2025
erickzhao
force-pushed
the
cli/only-emit-warning-once
branch
from
4ca98d7 to
b590144
Compare
erickzhao
changed the title
resolvePackageManager calls
…e into cli/only-emit-warning-once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #3822
This PR aims to minimize our usage of the
resolvePackageManagerutility by resolving the package manager once at the start of any API command and passing it through theListr2context.It also saves a boolean to see if we've warned about the
NODE_INSTALLERdeprecation at any point in the module's lifecycle so that we don't print excessive amounts of warnings.