Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(cli): only check for git on init #3846

Merged
merged 4 commits into from
Feb 13, 2025
Merged

perf(cli): only check for git on init #3846

merged 4 commits into from
Feb 13, 2025

Conversation

erickzhao
Copy link
Member

Similar to #3843, this PR does a systems check for git iff we're running import or init.

@erickzhao erickzhao requested a review from a team as a code owner February 11, 2025 00:39
@erickzhao erickzhao marked this pull request as draft February 11, 2025 01:38
@erickzhao erickzhao marked this pull request as ready for review February 13, 2025 01:05
@erickzhao erickzhao added this pull request to the merge queue Feb 13, 2025
19714
19714 reviewed Feb 13, 2025
View reviewed changes
packages/api/cli/src/electron-forge.ts

This comment was marked as spam.

Sign in to view

Merged via the queue into main with commit 5e43cf6 Feb 13, 2025
12 checks passed
@erickzhao erickzhao deleted the check-init-git branch February 13, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@19714 19714 19714 left review comments

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzhao @BlackHole1 @19714