Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

feat: add OpenJSF copy and logo to footer #3895

Merged
merged 8 commits into from
Jun 23, 2020
Merged

feat: add OpenJSF copy and logo to footer #3895

merged 8 commits into from
Jun 23, 2020

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Apr 27, 2020

Ref electron/governance#267

Do not merge this PR until the final steps of the OpenJSF transition are complete.

Restyles our footer to include the OpenJS Foundation legal copy and logo.

Note that the OpenJSF copy will always be in English regardless of website language set, which aligns with how nodejs.org does it, for instance.

cc @bnb @brianwarner

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

views/partials/footer.html Outdated Show resolved Hide resolved
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 April 27, 2020 16:59 Inactive
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 April 27, 2020 17:01 Inactive
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 April 27, 2020 17:12 Inactive
@erickzhao
Copy link
Member Author

Since I updated the layout, the unit tests need some fixing. 🙈

@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 April 27, 2020 17:19 Inactive
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 April 27, 2020 17:55 Inactive
@erickzhao erickzhao requested a review from a team April 27, 2020 22:44
@erickzhao erickzhao changed the title feat: add OpenJSF copy and logo to footer [donotmerge] feat: add OpenJSF copy and logo to footer Apr 28, 2020
@erickzhao erickzhao removed the request for review from a team May 14, 2020 15:48
@erickzhao erickzhao marked this pull request as draft June 8, 2020 23:27
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 June 22, 2020 17:40 Inactive
@erickzhao erickzhao marked this pull request as ready for review June 22, 2020 18:09
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 June 22, 2020 18:10 Inactive
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 June 22, 2020 18:18 Inactive
@erickzhao erickzhao requested a review from a team June 22, 2020 18:25
@vhashimotoo vhashimotoo self-requested a review June 22, 2020 22:25
@MarshallOfSound MarshallOfSound temporarily deployed to electron-website-pr-3895 June 22, 2020 22:28 Inactive
@electron-bot electron-bot temporarily deployed to electron-website-pr-3895 June 22, 2020 23:25 Inactive
@erickzhao erickzhao changed the title [donotmerge] feat: add OpenJSF copy and logo to footer feat: add OpenJSF copy and logo to footer Jun 23, 2020
@erickzhao erickzhao merged commit c971d36 into master Jun 23, 2020
@vhashimotoo vhashimotoo deleted the erick/openjsf branch June 30, 2020 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants