This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 650
feat: add OpenJSF copy and logo to footer #3895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
erickzhao
force-pushed
the
erick/openjsf
branch
from
April 27, 2020 17:00
b62c37a
to
69b4807
Compare
Since I updated the layout, the unit tests need some fixing. 🙈 |
erickzhao
force-pushed
the
erick/openjsf
branch
from
April 27, 2020 17:18
e71e02d
to
44e6647
Compare
30 tasks
erickzhao
changed the title
feat: add OpenJSF copy and logo to footer
[donotmerge] feat: add OpenJSF copy and logo to footer
Apr 28, 2020
vhashimotoo
approved these changes
Jun 23, 2020
erickzhao
changed the title
[donotmerge] feat: add OpenJSF copy and logo to footer
feat: add OpenJSF copy and logo to footer
Jun 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref electron/governance#267
Do not merge this PR until the final steps of the OpenJSF transition are complete.
Restyles our footer to include the OpenJS Foundation legal copy and logo.
Note that the OpenJSF copy will always be in English regardless of website language set, which aligns with how nodejs.org does it, for instance.
cc @bnb @brianwarner