-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support native MacOS screen capturer #43492
Draft
VerteDinde
wants to merge
10
commits into
main
Choose a base branch
from
sckp-macos15
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
target/33-x-y
PR should also be added to the "33-x-y" branch.
and removed
new-pr 🌱
PR opened in the last 24 hours
labels
Aug 27, 2024
dsanders11
reviewed
Aug 27, 2024
VerteDinde
force-pushed
the
sckp-macos15
branch
2 times, most recently
from
September 2, 2024 12:15
8081536
to
9a99cd9
Compare
VerteDinde
force-pushed
the
sckp-macos15
branch
from
September 5, 2024 19:02
9a99cd9
to
be470c8
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds support for MacOS 15 Sequoia's native system picker as part of the desktopCapturer API. The API now includes an
isDisplayMediaSystemPickerAvailable
check and an option togetNativePickerSource
, which returns the selected native picker media stream.This API does not allow a user to differentiate between screens and windows, following similar MacOS API implementations - we can add that differentiation to the API.
Currently in draft to take API comments/considerations.
Ref: https://issues.chromium.org/issues/40286360
Test Gist: https://gist.github.com/8e4e41c6606efea081add0487dd2cb6d
Checklist
npm test
passesRelease Notes
Notes: Added support for the macOS system picker in
desktopCaptuerer
andsetDisplayMediaRequestHandler