Fix typo in vite.md #167
Merged
Fix typo in vite.md #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6z3h
reviewed
Mar 31, 2024
config/plugins/vite.md
Outdated
| }, | ||
| { | ||
| "entry": "src/preload.js", | ||
| "config": "vite.preload.config.mjs", | ||
| "config": "vite.preload.config.mjs" | ||
| }, |
There was a problem hiding this comment.
good catch on the JSON errors, should the comma on this line be removed as well? I'm getting an error on local with this Trailing comma json(519)
There was a problem hiding this comment.
will be even better! done
erickzhao
approved these changes
May 14, 2024
|
Thank you @oktapodia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thank you for your project.
It seems that there is a typo into the code example there (an extra
})