Skip to content

fix(elixir-client): decode escaped backslashes in quoted array elements #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpruijsen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(elixir-client): decode escaped backslashes in quoted array elements #4829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/olive-llamas-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@core/elixir-client': patch
---

Fix `Electric.Client.EctoAdapter.ArrayDecoder` decoding of escaped backslashes in
quoted PostgreSQL array elements: `\\` now decodes to a single backslash, matching
PostgreSQL semantics and the TypeScript client's parser.
4 changes: 2 additions & 2 deletions packages/elixir-client/lib/electric/client/ecto_adapter/array_decoder.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ if Code.ensure_loaded?(Ecto) do
defp decode_quoted_elem(<<?", rest::bitstring>>, acc, state),
do: {rest, cast_quoted(acc, state)}

defp decode_quoted_elem(<<"\\\"", rest::bitstring>>, acc, state),
do: decode_quoted_elem(rest, [acc | [?"]], state)
defp decode_quoted_elem(<<?\\, c::utf8, rest::bitstring>>, acc, state),
do: decode_quoted_elem(rest, [acc | <<c::utf8>>], state)

defp decode_quoted_elem(<<c::utf8, rest::bitstring>>, acc, state),
do: decode_quoted_elem(rest, [acc | <<c::utf8>>], state)
Expand Down
3 changes: 3 additions & 0 deletions packages/elixir-client/test/electric/client/ecto_adapter/array_decoder_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ defmodule Electric.Client.EctoAdapter.ArrayDecoderTest do
"c"
]

assert ArrayDecoder.decode!(~S[{"a\\b"}], :string) == ["a\\b"]
assert ArrayDecoder.decode!(~S[{"a\\\\b"}], :string) == ["a\\\\b"]

assert ArrayDecoder.decode!(~S[{NULL,NULL,"NULL"}], :string) == [nil, nil, "NULL"]
end

Expand Down