Skip to content

Replace non-ASCII µs suffix in telemetry metric names - #4776

Merged
alco merged 4 commits into
mainfrom
fix-non-ascii-telemetry-metric-names
Sep 1, 2026
Merged

alco merged 4 commits into
mainfrom
fix-non-ascii-telemetry-metric-names

Conversation

@alco

@alco alco commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Renames the microsecond-unit suffix used by several telemetry metric and span-attribute names from the non-ASCII µs/μs characters to plain-ASCII us, since backends such as Mimir/Prometheus reject metric names containing non-ASCII characters and were dropping these metrics on ingestion.
  • Covers the shape DB connection pool checkout queue-time metric named directly in the issue, plus several interval/span-duration attribute names elsewhere in the sync-service that used the same non-ASCII suffix, for consistency.
  • Adds coverage confirming the renamed metric is exported with a plain-ASCII name.

Fixes #4732

@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.11%. Comparing base (7b9e9fe) to head (9b9cd9c).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4776       +/-   ##
===========================================
+ Coverage   43.29%   60.11%   +16.81%     
===========================================
  Files         314      409       +95     
  Lines       25624    44242    +18618     
  Branches     8705    12589     +3884     
===========================================
+ Hits        11094    26594    +15500     
- Misses      14449    17566     +3117     
- Partials       81       82        +1     
Flag Coverage Δ
electric-telemetry 64.39% <ø> (?)
elixir 64.39% <ø> (?)
packages/agents 72.77% <ø> (ø)
packages/agents-mcp 77.70% <ø> (ø)
packages/agents-mobile 80.67% <ø> (ø)
packages/agents-runtime 83.73% <ø> (?)
packages/agents-server 75.67% <ø> (+0.02%) ⬆️
packages/agents-server-ui 8.32% <ø> (ø)
packages/electric-ax 51.06% <ø> (ø)
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/start 82.83% <ø> (ø)
packages/typescript-client 91.84% <ø> (-0.12%) ⬇️
packages/y-electric 56.05% <ø> (ø)
typescript 60.06% <ø> (+16.76%) ⬆️
unit-tests 60.11% <ø> (+16.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alco
alco marked this pull request as ready for review August 26, 2026 15:04
@alco
alco force-pushed the fix-non-ascii-telemetry-metric-names branch from 33166a4 to 9b9cd9c Compare September 1, 2026 09:45
@alco
alco merged commit 1a50fff into main Sep 1, 2026
74 of 77 checks passed
@alco
alco deleted the fix-non-ascii-telemetry-metric-names branch September 1, 2026 09:50
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This PR has been released! 🚀

The following packages include changes from this PR:

  • @core/sync-service@1.8.0

Thanks for contributing to Electric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open telemetry rejected by Mimir/Prometheus

1 participant