Skip to content

Revert "feat(sync-service): Send individual operations to ShapeLogCollector (#3429) - #3464

Merged
robacourt merged 1 commit into
mainfrom
revert-failing-tests-pr
Nov 19, 2025
Merged

robacourt merged 1 commit into
mainfrom
revert-failing-tests-pr

Conversation

@robacourt

@robacourt robacourt commented Nov 19, 2025 •

Copy link
Copy Markdown
Contributor

This reverts commit c71fb58.

@robacourt
robacourt marked this pull request as ready for review November 19, 2025 10:10
@pkg-pr-new

pkg-pr-new Bot commented Nov 19, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@electric-sql/react@3464
npm i https://pkg.pr.new/@electric-sql/client@3464
npm i https://pkg.pr.new/@electric-sql/y-electric@3464

commit: 7ba38ef

@codecov

codecov Bot commented Nov 19, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.14286% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.56%. Comparing base (c71fb58) to head (7ba38ef).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ce/lib/electric/replication/shape_log_collector.ex 0.00% 22 Missing ⚠️
.../electric/postgres/replication_client/collector.ex 96.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   73.70%   67.56%   -6.15%     
==========================================
  Files          28      180     +152     
  Lines        1198     9672    +8474     
  Branches      106      357     +251     
==========================================
+ Hits          883     6535    +5652     
- Misses        314     3135    +2821     
- Partials        1        2       +1     
Flag Coverage Δ
elixir 64.16% <77.14%> (-10.32%) ⬇️
elixir-client 74.47% <ø> (ø)
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/typescript-client 93.57% <ø> (?)
packages/y-electric 55.12% <ø> (ø)
postgres-140000 62.81% <77.14%> (?)
postgres-150000 62.83% <77.14%> (?)
postgres-170000 62.79% <77.14%> (?)
postgres-180000 62.85% <77.14%> (?)
sync-service 63.11% <77.14%> (?)
typescript 87.06% <ø> (+14.66%) ⬆️
unit-tests 67.56% <77.14%> (-6.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robacourt robacourt changed the title Revert "feat(sync-service): Send individual operations to ShapeLogCol… Revert "feat(sync-service): Send individual operations to ShapeLogCollector (#3429) Nov 19, 2025
@robacourt
robacourt merged commit d606900 into main Nov 19, 2025
50 of 51 checks passed
@robacourt
robacourt deleted the revert-failing-tests-pr branch November 19, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants