-
Notifications
You must be signed in to change notification settings - Fork 87
Add conditions.agent.version
into integration and input manifest spec with validation
#999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add conditions.agent.version
into integration and input manifest spec with validation
#999
Conversation
test-integrations |
Created or updated PR in integrations repository to test this version. Check elastic/integrations#15665 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is agent.version
intended to be supported in all types of packages? In principle only input
and integration
packages contain agent configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this doesn't cause any issue on old versions of Fleet, I think we could allow this on any version of the spec.
- Refactor error handling in ValidateMinimumAgentVersion to check for valid semver constraints. - Adjust test cases to reflect changes in agent.version validation logic. - Modify integration manifest specifications to require agent.version as a constraint. - Update example manifests to use new versioning format.
… elastic and kibana to content packages
conditions.agent.version
into integration manifest spec with validationconditions.agent.version
into integration and input manifest spec with validation
…tegration packages
💛 Build succeeded, but was flaky
Failed CI Steps
History
|
What does this PR do?
Adds a new property into the integration and input spec to add the minimum agent version a package is compatible with.
The new field is required after 3.6
Why is it important?
The Elastic Agent running at Kibana, might not be compatible with the integration. This helps Fleet read the agent version an integration is compatible with and is able to warn the user if is not compatible.
Checklist
Added unit tests
Updated test packages for 3.6 version to include the now required field
I have added test packages to
test/packages
that prove my change is effective.I have added an entry in
spec/changelog.yml
.Related issues
Resolves #970