Upgrade EUI to v18.3.0 #56228

thompsongl · 2020-01-28T20:25:23Z

[email protected] ⏩ [email protected]

A healthy amount of TypeScript conversion
New 3+1 app logo icons
New homepage layout highlighting observability and security

`18.3.0`

Converted EuiModal and EuiConfirmModal to TypeScript (#2742)
Converted EuiTabs to TypeScript (#2717)
Converted EuiFormRow to TypeScript (#2712)
Updated logoAPM, logoSecurity and logoEnterpriseSearch. Added logoWorkplaceSearch and logoObservability (#2769)
Converted EuiFilterButton to TypeScript (#2761)
Converted EuiFilterSelectItem to TypeScript (#2761)
Converted EuiFieldSearch to TypeScript (#2775)
Added data-test-subj to the EuiContextMenuItem in EuiTablePagination (#2778)
Improved EuiIcon a11y by using a title and aria-labelledby (#2786)
Improved compressed EuiPagination by including active and last page numbers (#2779)
Converted EuiSuperSelect to TypeScript (#2776)

Bug fixes

Increased column width on EuiTableHeaderCellCheckbox to prevent EuiCheckbox's focus ring from getting clipped in EuiBasicTable (#2770)
Fixed the display of EuiButton within EuiControlBar when fill={true} to be more consistent with other buttons (#2781)
Fixed EuiFormControlLayout from overwriting className for prepend nodes. (#2796)
Fixed useRenderToText and EuiButtonToggle from attempting state updates on unmounted components (#2797)
Refactored function and hook instantiation to fix drag action sluggishness in EuiColorStops (#2557)

Deprecations

EuiIcon's logoEnterpriseSearch type deprecated in favor of logoWorkplaceSearch
EuiIcon's logoAPM type deprecated in favor of logoObservability

lukeelmers

Updates to app arch jest snapshots lgtm

thompsongl · 2020-01-29T20:23:09Z

I believe @snide is going to add a commit or two to this branch to update the homepage with new logos

snide · 2020-01-29T20:28:46Z

Yep. I'll get that in today.

snide · 2020-01-30T05:36:18Z

Homepage treatment similar to what we did in 7.6. Also updated the nav icons for what we have so far. Still waiting on the analytics logo.

ryankeairns · 2020-01-30T15:24:04Z

Knowing that the home page redesign is imminent, maybe just some minor alignment tweaks.

Thoughts on left-aligning content in the top section to better match with bottom panels? I think this approach has things looking less like they are floating in space:

snide · 2020-01-30T15:25:15Z

@ryankeairns Can do.

cchaos · 2020-01-30T15:28:07Z

I agree with @ryankeairns' suggestion. Left align works a lot better. Could you also either decrease the size of the logos or increase the size of the titles? Also, have you tested how it responds to smaller browser widths?

snide · 2020-01-30T17:00:03Z

Edits made. It works responsively.

snide

Good to go from design.

joshdover

Platform changes LGTM

joshdover · 2020-01-31T21:42:36Z

docs/development/core/public/kibana-plugin-public.chromenavlink.disablesuburltracking.md

-```typescript
-readonly disableSubUrlTracking?: boolean;
-```
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->


I think you may have ran the update script here based on an older version of master. We've been battling with getting these files to use the same EOL character. After merging master, can you run this again and commit any changes? node scripts/check_core_api_changes --docs

No changes after merging master running the script

thompsongl · 2020-02-03T15:26:48Z

@elasticmachine merge upstream

simianhacker · 2020-02-03T15:57:34Z

Closes #49677

kibanamachine · 2020-02-03T16:51:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b847aa0

History

💚 Build #23853 succeeded d418e2f
💚 Build #23623 succeeded 9750b11
💔 Build #23607 failed ee3dfbf
💔 Build #23578 failed 36d70fe
💔 Build #23559 failed 729f8d9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

poffdeluxe

Canvas changes lgtm

thomasneirynck

Maps lgtm

* eui to 18.3.0 * ts interface update * src snapshot updates * x-pack snapshot updates * icons in nav * Homepage updates, nav drawer and tests * feedback * more feedback * euiIconType for observability and security * remove unused translations Co-authored-by: [email protected] <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

* eui to 18.3.0 * ts interface update * src snapshot updates * x-pack snapshot updates * icons in nav * Homepage updates, nav drawer and tests * feedback * more feedback * euiIconType for observability and security * remove unused translations Co-authored-by: [email protected] <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

* master: (42 commits) Move kuery_autocomplete ⇒ NP (elastic#56607) [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595) [Discover] Inline angular directives only used in this plugin (elastic#56119) [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011) [SIEM] Enable flow_target_select_connected unit tests (elastic#55618) Start consuming np logging config (elastic#56480) [SIEM] Add eslint-plugin-react-perf (elastic#55960) Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613) Add `getServerInfo` API to http setup contract (elastic#56636) Updates Monitoring alert Jest snapshots Kibana property config migrations (elastic#55937) Vislib replacement toggle (elastic#56439) [Uptime] Add unit tests for QueryContext time calculation (elastic#56671) [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts Upgrade EUI to v18.3.0 (elastic#56228) [Maps] Fix server log (elastic#56679) [SIEM] Fixes FTUE when APM node is present (elastic#56574) [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563) Update EMS API urls for production (elastic#56657) Ability to delete alerts even when AAD is out of sync (elastic#56543) ...

thompsongl added 4 commits January 28, 2020 13:39

eui to 18.3.0

23812f9

ts interface update

c62c0fe

src snapshot updates

e5976bc

x-pack snapshot updates

875be6d

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.7.0 labels Jan 28, 2020

thompsongl requested a review from snide January 28, 2020 20:25

Merge branch 'master' into eui/18.3.0

452c39d

thompsongl marked this pull request as ready for review January 29, 2020 18:56

thompsongl requested a review from a team as a code owner January 29, 2020 18:56

thompsongl requested a review from a team January 29, 2020 18:56

thompsongl requested review from a team as code owners January 29, 2020 18:56

lukeelmers approved these changes Jan 29, 2020

View reviewed changes

jbudz approved these changes Jan 29, 2020

View reviewed changes

snide added 2 commits January 29, 2020 20:39

icons in nav

2b604b6

Homepage updates, nav drawer and tests

5169baa

thompsongl requested a review from a team as a code owner January 30, 2020 05:07

Merge remote-tracking branch 'upstream/master' into eui/18.3.0

4576b43

snide added 2 commits January 30, 2020 07:45

feedback

729f8d9

more feedback

36d70fe

thompsongl added 2 commits January 30, 2020 12:20

Merge branch 'master' into eui/18.3.0

ad68186

euiIconType for observability and security

ee3dfbf

snide approved these changes Jan 30, 2020

View reviewed changes

thompsongl added 2 commits January 30, 2020 13:36

remove unused translations

9c30ff1

Merge branch 'master' into eui/18.3.0

9750b11

joshdover approved these changes Jan 31, 2020

View reviewed changes

Merge branch 'master' into eui/18.3.0

d418e2f

Merge branch 'master' into eui/18.3.0

b847aa0

simianhacker mentioned this pull request Feb 3, 2020

[Metrics UI] Error in console when switching from Inventory View #49677

Closed

legrego self-requested a review February 3, 2020 17:56

kobelb approved these changes Feb 3, 2020

View reviewed changes

legrego removed their request for review February 3, 2020 18:09

poffdeluxe approved these changes Feb 3, 2020

View reviewed changes

thomasneirynck approved these changes Feb 3, 2020

View reviewed changes

thompsongl merged commit 94be839 into elastic:master Feb 3, 2020

thompsongl mentioned this pull request Feb 3, 2020

[7.x] Upgrade EUI to v18.3.0 (#56228) #56702

Merged

tylersmalley mentioned this pull request Feb 4, 2020

[Monitoring] Migrate license expiration alert to Kibana alerting #54306

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v18.3.0 #56228

Upgrade EUI to v18.3.0 #56228

thompsongl commented Jan 28, 2020 •

edited

Loading

lukeelmers left a comment

thompsongl commented Jan 29, 2020

snide commented Jan 29, 2020

snide commented Jan 30, 2020

ryankeairns commented Jan 30, 2020

snide commented Jan 30, 2020

cchaos commented Jan 30, 2020

snide commented Jan 30, 2020

snide left a comment

joshdover left a comment

joshdover Jan 31, 2020

thompsongl Jan 31, 2020

thompsongl commented Feb 3, 2020

simianhacker commented Feb 3, 2020

kibanamachine commented Feb 3, 2020

poffdeluxe left a comment

thomasneirynck left a comment

Upgrade EUI to v18.3.0 #56228

Upgrade EUI to v18.3.0 #56228

Conversation

thompsongl commented Jan 28, 2020 • edited Loading

18.3.0

lukeelmers left a comment

Choose a reason for hiding this comment

thompsongl commented Jan 29, 2020

snide commented Jan 29, 2020

snide commented Jan 30, 2020

ryankeairns commented Jan 30, 2020

snide commented Jan 30, 2020

cchaos commented Jan 30, 2020

snide commented Jan 30, 2020

snide left a comment

Choose a reason for hiding this comment

joshdover left a comment

Choose a reason for hiding this comment

joshdover Jan 31, 2020

Choose a reason for hiding this comment

thompsongl Jan 31, 2020

Choose a reason for hiding this comment

thompsongl commented Feb 3, 2020

simianhacker commented Feb 3, 2020

kibanamachine commented Feb 3, 2020

💚 Build Succeeded

History

poffdeluxe left a comment

Choose a reason for hiding this comment

thomasneirynck left a comment

Choose a reason for hiding this comment

thompsongl commented Jan 28, 2020 •

edited

Loading

`18.3.0`