Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.6] Upgrade EUI to v18.2.2 #56206

Merged
merged 5 commits into from
Jan 29, 2020
Merged

[7.6] Upgrade EUI to v18.2.2 #56206

merged 5 commits into from
Jan 29, 2020

Conversation

thompsongl
Copy link
Contributor

  • Adds new solution logo icons (3+1 update)
  • Fixes a React state update warning/bug seen by the SIEM and Observability teams

18.2.2

  • Updated logoAPM, logoSecurity and logoEnterpriseSearch. Added logoWorkplaceSearch and logoObservability (#2769)

Bug fixes

  • Fixed useRenderToText and EuiButtonToggle from attempting state updates on unmounted components (#2797)

@thompsongl thompsongl added release_note:skip Skip the PR/issue when compiling release notes EUI v7.6.0 labels Jan 28, 2020
@snide
Copy link
Contributor

snide commented Jan 28, 2020

FYI. I'll be adding a commit on top of this to adjust some logos around.

@thompsongl thompsongl mentioned this pull request Jan 28, 2020
Closed
2 tasks
andrew-goldstein
andrew-goldstein approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 @thompsongl, the version changes LGTM

@snide
Copy link
Contributor

snide commented Jan 29, 2020

image

@formgeist I went ahead and implemented your initial idea. This is for 7.6. Going forward in 7.7 I'm hoping the integration manager homepage can come in and sweep all this stuff away, but at least this gets us close to our branding.

cc @alexfrancoeur

@snide snide requested a review from formgeist January 29, 2020 01:52
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

snide
snide approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @thompsongl I think we're safe to merge.

@thompsongl thompsongl merged commit 8481b8f into elastic:7.6 Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

@formgeist formgeist formgeist approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thompsongl @snide @kibanamachine @formgeist @andrew-goldstein