[Discover] Breakdown support for fieldstats #199028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedhamed-ahmed
added
release_note:skip
jughosta
reviewed
Nov 6, 2024
src/plugins/discover/public/application/main/components/layout/discover_layout.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/main/components/layout/discover_layout.tsx
Show resolved
Hide resolved
src/plugins/discover/public/application/main/components/layout/discover_layout.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/main/components/layout/discover_layout.tsx
Outdated
Show resolved
Hide resolved
packages/kbn-unified-field-list/src/components/field_popover/field_popover_header.tsx
Outdated
Show resolved
Hide resolved
…ithub.com/mohamedhamed-ahmed/kibana into 192700-fieldstats-popover-breakdown-field
packages/kbn-data-view-utils/src/utils/convert_to_data_table_column.ts
Outdated
Show resolved
Hide resolved
packages/kbn-unified-field-list/src/components/field_popover/field_popover_header.tsx
Outdated
Show resolved
Hide resolved
…ithub.com/mohamedhamed-ahmed/kibana into 192700-fieldstats-popover-breakdown-field
mohamedhamed-ahmed
added
backport:prev-minor
…ithub.com/mohamedhamed-ahmed/kibana into 192700-fieldstats-popover-breakdown-field
mohamedhamed-ahmed
added
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
tonyghiani
approved these changes
Nov 11, 2024
|
@mohamedhamed-ahmed do we want to disable the icon if the breakdown is already applied? 
Not so important, just asking |
Had same question in mind, and discussed it with @jughosta but then we agreed to keep it and not hide it |
stratoula
approved these changes
Nov 11, 2024
jughosta
reviewed
Nov 11, 2024
|
|
||
| return true; | ||
| export const isESQLFieldGroupable = (field: FieldSpec): boolean => { | ||
| if (field.timeSeriesMetric === 'counter') return false; |
There was a problem hiding this comment.
Suggested change
| if (field.timeSeriesMetric === 'counter') return false; | |
| if (field.timeSeriesMetric) return false; |
Other cases like histogram I guess also would not work.
There was a problem hiding this comment.
They are not supported by ESQL yet. What other options can this timeseriesMetric take? Let's evaluate first before doing the suggested change
There was a problem hiding this comment.
Here are possible values for data view mode
kibana/x-pack/plugins/lens/public/types.ts
Line 111 in a854ff8
It does not exactly apply to ES|QL at the moment but it might in the future.
There was a problem hiding this comment.
I see, thanx for sharing Julia.
In the columns function we check for counter related metrics as only these are partially supported by ESQL and only for these we know for sure that they are not groupable.
We have 2 options. Either keep it as it is (which aligns with the above function) or change both.
I personally prefer the first option. (Aligns with the existing column function too). When more tsdb metrics will be added we should test (and update if is the case the isGroupable functionality). But I dont have a strong opinion, mostly a preference
packages/kbn-unified-field-list/src/components/field_popover/field_popover_header.tsx
Outdated
Show resolved
Hide resolved
packages/kbn-unified-field-list/src/containers/unified_field_list_item/field_list_item.tsx
Show resolved
Hide resolved
...ages/kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.tsx
Show resolved
Hide resolved
⏳ Build in-progress
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
closes elastic#192700 ## 📝 Summary This PR add a new `Add breakdown` button to the field stats popover for all applicable fields. ## 🎥 Demo https://github.com/user-attachments/assets/d647189c-9b04-4127-a4fd-f9764babe46e --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 7369442)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Nov 12, 2024
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
closes elastic#192700 ## 📝 Summary This PR add a new `Add breakdown` button to the field stats popover for all applicable fields. ## 🎥 Demo https://github.com/user-attachments/assets/d647189c-9b04-4127-a4fd-f9764babe46e --------- Co-authored-by: kibanamachine <[email protected]>
3 tasks
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Breakdown support for fieldstats (#199028)](#199028) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T12:26:36Z","message":"[Discover] Breakdown support for fieldstats (#199028)\n\ncloses https://github.com/elastic/kibana/issues/192700\r\n\r\n## 📝 Summary\r\n\r\nThis PR add a new `Add breakdown` button to the field stats popover for\r\nall applicable fields.\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d647189c-9b04-4127-a4fd-f9764babe46e\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"73694426f943f00f74556406dcb26c66eb4a772a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Discover] Breakdown support for fieldstats","number":199028,"url":"https://github.com/elastic/kibana/pull/199028","mergeCommit":{"message":"[Discover] Breakdown support for fieldstats (#199028)\n\ncloses https://github.com/elastic/kibana/issues/192700\r\n\r\n## 📝 Summary\r\n\r\nThis PR add a new `Add breakdown` button to the field stats popover for\r\nall applicable fields.\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d647189c-9b04-4127-a4fd-f9764babe46e\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"73694426f943f00f74556406dcb26c66eb4a772a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199028","number":199028,"mergeCommit":{"message":"[Discover] Breakdown support for fieldstats (#199028)\n\ncloses https://github.com/elastic/kibana/issues/192700\r\n\r\n## 📝 Summary\r\n\r\nThis PR add a new `Add breakdown` button to the field stats popover for\r\nall applicable fields.\r\n\r\n## 🎥 Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d647189c-9b04-4127-a4fd-f9764babe46e\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"73694426f943f00f74556406dcb26c66eb4a772a"}}]}] BACKPORT--> Co-authored-by: mohamedhamed-ahmed <[email protected]>
kibanamachine
added
v8.17.0
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #192700
📝 Summary
This PR add a new
Add breakdownbutton to the field stats popover for all applicable fields.🎥 Demo
Screen.Recording.2024-11-07.at.14.07.50.mov