[ml] Optimize bundles, reduce page load async chunks by 74%

x-pack/packages/ml/agg_utils/src/fetch_histograms_for_fields.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import get from 'lodash/get';
+import { get } from 'lodash';
 
 import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
 

x-pack/packages/ml/response_stream/client/fetch_stream.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import startsWith from 'lodash/startsWith';
+import { startsWith } from 'lodash';
 import type { Reducer, ReducerAction } from 'react';
 
 import type { HttpSetup, HttpFetchOptions } from '@kbn/core/public';

x-pack/plugins/ml/common/index.ts

@@ -10,3 +10,4 @@ export { getDefaultCapabilities as getDefaultMlCapabilities } from './types/capa
 export { DATAFEED_STATE, JOB_STATE } from './constants/states';
 export type { MlSummaryJob, SummaryJobState } from './types/anomaly_detection_jobs';
 export { ML_ALERT_TYPES } from './constants/alerts';
+export type { Job, Datafeed } from './types/anomaly_detection_jobs';

x-pack/plugins/ml/public/application/app.tsx

@@ -10,9 +10,7 @@ import './_index.scss';
 import ReactDOM from 'react-dom';
 import { pick } from 'lodash';
 
-import type { DataViewsContract } from '@kbn/data-views-plugin/public';
-import type { AppMountParameters, CoreStart, HttpStart } from '@kbn/core/public';
-import type { UsageCollectionSetup } from '@kbn/usage-collection-plugin/public';
+import type { AppMountParameters, CoreStart } from '@kbn/core/public';
 import { DatePickerContextProvider, type DatePickerDependencies } from '@kbn/ml-date-picker';
 import { Storage } from '@kbn/kibana-utils-plugin/public';
 import { UI_SETTINGS } from '@kbn/data-plugin/common';
@@ -21,21 +19,15 @@ import { StorageContextProvider } from '@kbn/ml-local-storage';
 import useLifecycles from 'react-use/lib/useLifecycles';
 import useObservable from 'react-use/lib/useObservable';
 import type { ExperimentalFeatures, MlFeatures } from '../../common/constants/app';
-import { MlLicense } from '../../common/license';
-import { MlCapabilitiesService } from './capabilities/check_capabilities';
 import { ML_STORAGE_KEYS } from '../../common/types/storage';
 import type { MlSetupDependencies, MlStartDependencies } from '../plugin';
 import { clearCache, setDependencyCache } from './util/dependency_cache';
 import { setLicenseCache } from './license';
-import { mlUsageCollectionProvider } from './services/usage_collection';
 import { MlRouter } from './routing';
-import { mlApiServicesProvider } from './services/ml_api_service';
-import { HttpService } from './services/http_service';
 import type { PageDependencies } from './routing/router';
 import { EnabledFeaturesContextProvider } from './contexts/ml';
 import type { StartServices } from './contexts/kibana';
-import { fieldFormatServiceFactory } from './services/field_format_service_factory';
-import { indexServiceFactory } from './util/index_service';
+import { getMlGlobalServices } from './util/get_services';
 
 export type MlDependencies = Omit<
   MlSetupDependencies,
@@ -54,38 +46,6 @@ interface AppProps {
 
 const localStorage = new Storage(window.localStorage);
 
-/**
- * Provides global services available across the entire ML app.
- */
-export function getMlGlobalServices(
-  httpStart: HttpStart,
-  dataViews: DataViewsContract,
-  usageCollection?: UsageCollectionSetup
-) {
-  const httpService = new HttpService(httpStart);
-  const mlApiServices = mlApiServicesProvider(httpService);
-  // Note on the following services:
-  // - `mlIndexUtils` is just instantiated here to be passed on to `mlFieldFormatService`,
-  //   but it's not being made available as part of global services. Since it's just
-  //   some stateless utils `useMlIndexUtils()` should be used from within components.
-  // - `mlFieldFormatService` is a stateful legacy service that relied on "dependency cache",
-  //   so because of its own state it needs to be made available as a global service.
-  //   In the long run we should again try to get rid of it here and make it available via
-  //   its own context or possibly without having a singleton like state at all, since the
-  //   way this manages its own state right now doesn't consider React component lifecycles.
-  const mlIndexUtils = indexServiceFactory(dataViews);
-  const mlFieldFormatService = fieldFormatServiceFactory(mlApiServices, mlIndexUtils);
-
-  return {
-    httpService,
-    mlApiServices,
-    mlFieldFormatService,
-    mlUsageCollection: mlUsageCollectionProvider(usageCollection),
-    mlCapabilities: new MlCapabilitiesService(mlApiServices),
-    mlLicense: new MlLicense(),
-  };
-}
-
 export interface MlServicesContext {
   mlServices: MlGlobalServices;
 }