Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v93.0.0 #176246

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Upgrade EUI to v93.0.0 #176246

merged 8 commits into from
Feb 8, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Feb 5, 2024 •
edited
Loading

v92.2.1 ⏩ v93.0.0

v93.0.0

Bug fixes

  • Fixed EuiTextTruncate component to clean up timer from side effect on unmount (#7495)

Breaking changes

  • Removed deprecated anchorClassName prop from EuiPopover. Use className instead (#7488)
  • Removed deprecated buttonRef prop from EuiPopover. Use popoverRef instead (#7488)
  • Removed deprecated toolTipTitle and toolTipPosition props from EuiContextMenuItem. Use toolTipProps.title and toolTipProps.position instead (#7489)
  • Removed deprecated internal setSelection ref method from EuiInMemoryTable and EuiBasicTable. Use the new controlled selection.selected prop API instead. (#7491)
  • EuiTourStep's className and style props now apply to the anchoring element instead of to the popover panel, to match EuiPopover behavior. (#7497)
    • Convert your existing usages to panelClassName and panelStyle respectively instead.

Performance

  • Improved the amount of recomputed styles being generated by EuiCode and EuiCodeBlock (#7486)

CSS-in-JS conversions

  • Converted EuiSearchBar to Emotion (#7490)
  • Converted EuiEmptyPrompt to Emotion (#7494)
  • Added euiBorderColor and useEuiBorderColorCSS style utilities (#7494)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.13.0 labels Feb 5, 2024
@cee-chen
Copy link
Member Author

cee-chen commented Feb 5, 2024

/ci

@cee-chen cee-chen marked this pull request as ready for review February 5, 2024 21:46
@cee-chen cee-chen requested review from a team as code owners February 5, 2024 21:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

mattkime
mattkime approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data discovery changes look good to me

@Heenawter Heenawter self-requested a review February 5, 2024 22:33
Heenawter
Heenawter approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single snapshot test change - code review only, LGTM 👍

stratoula
stratoula approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis team snaphsot update LGTM!

ElenaStoeva
ElenaStoeva approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ILM test snapshot changes LGTM.

@stratoula stratoula mentioned this pull request Feb 7, 2024
Merged
@cee-chen
Copy link
Member Author

cee-chen commented Feb 7, 2024

@elastic/security-solution 👋 One last ping for reviews - I'll be asking KibanaOps for an admin merge by EOD tomorrow otherwise.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 572.3KB 572.3KB +6.0B
infra 1.3MB 1.3MB +1.0KB
maps 2.9MB 2.9MB +1.0KB
securitySolution 11.4MB 11.4MB -5.0B
visTypeVega 1.8MB 1.8MB +1.0KB
total +3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 384.6KB 384.6KB +12.0B
globalSearchBar 27.4KB 27.4KB +1.0B
kbnUiSharedDeps-css 286.2KB 282.1KB -4.1KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +5.8KB
kbnUiSharedDeps-srcJs 2.9MB 2.9MB -1.0B
total +1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit cb5cf0e into elastic:main Feb 8, 2024
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 8, 2024
@cee-chen cee-chen deleted the eui-v93.0.0 branch February 9, 2024 01:02
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@cee-chen @jbudz @CoenWarmer
Upgrade EUI to v93.0.0 (elastic#176246)
804138c 
`v92.2.1` ⏩ `v93.0.0`

---

## [`v93.0.0`](https://github.com/elastic/eui/releases/v93.0.0)

**Bug fixes**

- Fixed `EuiTextTruncate` component to clean up timer from side effect
on unmount ([elastic#7495](elastic/eui#7495))

**Breaking changes**

- Removed deprecated `anchorClassName` prop from `EuiPopover`. Use
`className` instead ([elastic#7488](elastic/eui#7488))
- Removed deprecated `buttonRef` prop from `EuiPopover`. Use
`popoverRef` instead ([elastic#7488](elastic/eui#7488))
- Removed deprecated `toolTipTitle` and `toolTipPosition` props from
`EuiContextMenuItem`. Use `toolTipProps.title` and
`toolTipProps.position` instead
([elastic#7489](elastic/eui#7489))
- Removed deprecated internal `setSelection` ref method from
`EuiInMemoryTable` and `EuiBasicTable`. Use the new controlled
`selection.selected` prop API instead.
([elastic#7491](elastic/eui#7491))
- `EuiTourStep`'s `className` and `style` props now apply to the
anchoring element instead of to the popover panel, to match `EuiPopover`
behavior. ([elastic#7497](elastic/eui#7497))
- Convert your existing usages to `panelClassName` and `panelStyle`
respectively instead.

**Performance**

- Improved the amount of recomputed styles being generated by `EuiCode`
and `EuiCodeBlock` ([elastic#7486](elastic/eui#7486))

**CSS-in-JS conversions**

- Converted `EuiSearchBar` to Emotion
([elastic#7490](elastic/eui#7490))
- Converted `EuiEmptyPrompt` to Emotion
([elastic#7494](elastic/eui#7494))
- Added `euiBorderColor` and `useEuiBorderColorCSS` style utilities
([elastic#7494](elastic/eui#7494))

---------

Co-authored-by: Jon <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@cee-chen @jbudz @fkanout
Upgrade EUI to v93.0.0 (elastic#176246)
8a666bf 
`v92.2.1` ⏩ `v93.0.0`

---

## [`v93.0.0`](https://github.com/elastic/eui/releases/v93.0.0)

**Bug fixes**

- Fixed `EuiTextTruncate` component to clean up timer from side effect
on unmount ([elastic#7495](elastic/eui#7495))

**Breaking changes**

- Removed deprecated `anchorClassName` prop from `EuiPopover`. Use
`className` instead ([elastic#7488](elastic/eui#7488))
- Removed deprecated `buttonRef` prop from `EuiPopover`. Use
`popoverRef` instead ([elastic#7488](elastic/eui#7488))
- Removed deprecated `toolTipTitle` and `toolTipPosition` props from
`EuiContextMenuItem`. Use `toolTipProps.title` and
`toolTipProps.position` instead
([elastic#7489](elastic/eui#7489))
- Removed deprecated internal `setSelection` ref method from
`EuiInMemoryTable` and `EuiBasicTable`. Use the new controlled
`selection.selected` prop API instead.
([elastic#7491](elastic/eui#7491))
- `EuiTourStep`'s `className` and `style` props now apply to the
anchoring element instead of to the popover panel, to match `EuiPopover`
behavior. ([elastic#7497](elastic/eui#7497))
- Convert your existing usages to `panelClassName` and `panelStyle`
respectively instead.

**Performance**

- Improved the amount of recomputed styles being generated by `EuiCode`
and `EuiCodeBlock` ([elastic#7486](elastic/eui#7486))

**CSS-in-JS conversions**

- Converted `EuiSearchBar` to Emotion
([elastic#7490](elastic/eui#7490))
- Converted `EuiEmptyPrompt` to Emotion
([elastic#7494](elastic/eui#7494))
- Added `euiBorderColor` and `useEuiBorderColorCSS` style utilities
([elastic#7494](elastic/eui#7494))

---------

Co-authored-by: Jon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@gsoldevila gsoldevila gsoldevila approved these changes

@justinkambic justinkambic justinkambic approved these changes

@stratoula stratoula stratoula approved these changes

@Heenawter Heenawter Heenawter approved these changes

@jbudz jbudz jbudz approved these changes

@sebelga sebelga sebelga approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@SiddharthMantri SiddharthMantri SiddharthMantri approved these changes

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.