Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] JSON diff view PoC (monaco editor) #172125

Closed
wants to merge 10 commits into from

Conversation

banderror
Copy link
Contributor

Summary

Based on #172118

Contains a POC of rule JSON diff component based on the Monaco editor.

@banderror banderror force-pushed the rule-json-diff-poc-monaco branch 2 times, most recently from ab68755 to 3e849b8 Compare November 29, 2023 04:04
@banderror banderror force-pushed the rule-json-diff-poc-monaco branch from 3e849b8 to fe31be5 Compare November 29, 2023 04:19
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 29, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4733 4739 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 427.6KB 427.7KB +118.0B
discover 589.4KB 589.5KB +122.0B
kibanaReact 214.5KB 214.6KB +122.0B
securitySolution 12.9MB 12.9MB +5.5KB
total +5.9KB

History

  • 💔 Build #179854 failed 3e849b8388a49d1922cc24a18ffe90155b3054d2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@banderror banderror closed this Dec 28, 2023
@banderror banderror deleted the rule-json-diff-poc-monaco branch December 28, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants