Upgrade EUI to v79.0.1 #156925

cee-chen · 2023-05-05T21:17:22Z

Summary

[email protected] ⏩ [email protected]

🦴 The primary changes in this upgrade are around the deprecated EuiLoadingContent being removed in favor of EuiSkeletonText.

Most instances have been a direct swap of usage, but some replacements were a bit more opinionated as I saw them as potential to take advantage of EuiSkeletonText's syntactical sugar and screen reader announcements for when state switches to loaded.

`79.0.1`

Bug fixes

Fixed broken push EuiFlyout behavior (#6764)

`79.0.0`

Updated all EuiSkeleton components with new props that allow for more control over screen reader live announcements: announceLoadingStatus, announceLoadedStatus, and ariaLiveProps (#6752)
Improved keyboard accessibility in EuiPageHeader by ensuring the right side menu items come into focus from left to right. (#6753)

Breaking changes

Removed deprecated EuiLoadingContent. Use the EuiSkeleton components instead. (#6754)

`78.0.0`

Improved the contrast ratio of EuiCheckbox, EuiRadio, and EuiSwitch in their unchecked states to meet WCAG AA guidelines. (#6729)
Added React Testing Library *ByTestSubject custom commands to within(). RTL utilities can be imported from @elastic/eui/lib/test/rtl. (#6737)
Updated EuiAvatar to support a new letter casing prop that allow customizing text capitalization (#6739)
Updated EuiFocusTrap to support the gapMode prop configuration (now defaults to padding) (#6744)

Bug fixes

Fixed inconsistency in EuiSearchBar's AND/OR semantics between DSL and query string generation (#6717)
Fixed EuiFieldNumber's native browser validity detection causing extra unnecessary rerenders (#6741)
Fixed the scrollLock property on EuiFocusTrap (and other components using EuiFocusTrap, such as EuiFlyout and EuiModal) to no longer block scrolling on nested portalled content, such as combobox dropdowns (#6744)

Breaking changes

EuiAvatars with the default user type will now default to capitalizing all initials in uppercase (#6739)

JasonStoltz · 2023-05-09T13:38:02Z

@cee-chen FYI, a couple of the changes you have listed in the description appear to be part of the last upgrade from Trevor (#155208):

Updated EuiFocusTrap to support the gapMode prop configuration (now defaults to padding) ([EuiFocusTrap] Workaround for scrollLock prop causing nested portals/popovers to be unscrollable eui#6744)
Fixed the scrollLock property on EuiFocusTrap (and other components using EuiFocusTrap, such as EuiFlyout and EuiModal) to no longer block scrolling on nested portalled content, such as combobox dropdowns ([EuiFocusTrap] Workaround for scrollLock prop causing nested portals/popovers to be unscrollable eui#6744)
Fixed EuiFieldNumber's native browser validity detection causing extra unnecessary rerenders ([EuiFieldNumber] Clean up native :invalid detection eui#6741)

cee-chen · 2023-05-09T15:49:05Z

Yes, that's part of the backport process. The commits are cherry-picked into a release that the current Kibana upgrade can use (without pulling in everything else in main) but still need to be released on main. The changelog should be left as-is for consumers that aren't Kibana and did not get the backport-specific releases.

- using this API has improved screen reader accessibility + announcements on load

- new EuiSkeletonText CSS should not have any margin-bottom to unset

cee-chen · 2023-05-12T02:08:15Z

@elasticmachine merge upstream

jughosta

Data Discovery changes LGTM 👍

nreese

kibana-gis changes LGTM

kc13greiner

LGTM!

efegurkan

Enterprise Search changes look good.

Locally checked all seems to be working.

1Copenut

👍 LGTM! I viewed a number of pages with the network throttled to fast 3G so I could see the EuiSkeleton in action. Thanks Cee!

stephmilovic

Explore changes LGTM, thanks for the updates @cee-chen 🚀

dominiqueclarke

Uptime changes LGTM! 🚢

spong

Detection Rules Area changes LGTM! Thanks for all the goodness here @cee-chen! 🙂

tsullivan

Appex-SharedUX changes LGTM

YulNaumenko

Security Solution changes LGTM

cnasikas

ResponseOps changes LGTM!

xcrzx

Rules Area changes LGTM!

mohamedhamed-ahmed

Infra changes LGTM! Thank you

ogupte

Looks good for APM UI

cee-chen · 2023-05-15T16:01:40Z

@elasticmachine merge upstream

cee-chen · 2023-05-15T16:02:30Z

@elastic/security-solution-platform @elastic/ml-ui @dasansol92 @tomsonpl As a heads up, I'll be requesting that KibanaOps admin merge in this PR by EOD today. Please review/approve if you can before then!

peteharverson

ML changes LGTM

peteharverson

ML changes LGTM

cee-chen · 2023-05-15T18:53:25Z

@elasticmachine merge upstream

kibana-ci · 2023-05-15T22:27:08Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 47cf567

Failed CI Steps

Test Failures

[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detections : Page Filters "after each" hook for "Changed banner should hide on Reset"
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detections : Page Filters Changed banner should hide on Reset
[job] [logs] FTR Configs #1 / ObservabilityApp Observability alerts / Add to case > When user has all privileges for cases renders case options in the overflow menu

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	794.1KB	794.1KB	-2.0B
`apm`	3.5MB	3.5MB	-16.0B
`cases`	374.5KB	374.5KB	-6.0B
`console`	417.9KB	417.9KB	-2.0B
`dataViewManagement`	118.6KB	118.6KB	-2.0B
`enterpriseSearch`	2.4MB	2.4MB	+18.0B
`indexLifecycleManagement`	157.8KB	157.8KB	-2.0B
`infra`	2.0MB	2.0MB	-4.0B
`maps`	2.7MB	2.7MB	-2.0B
`ml`	3.4MB	3.4MB	+10.0B
`observability`	971.5KB	971.5KB	-2.0B
`osquery`	1.1MB	1.1MB	-14.0B
`security`	565.8KB	565.8KB	+13.0B
`securitySolution`	9.2MB	9.2MB	-229.0B
`snapshotRestore`	266.8KB	266.8KB	-2.0B
`synthetics`	1.2MB	1.2MB	-301.0B
`transform`	386.6KB	386.6KB	-2.0B
`triggersActionsUi`	1.4MB	1.4MB	+5.0B
`upgradeAssistant`	152.3KB	152.3KB	-6.0B
total			-546.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`aiops`	6.0KB	6.0KB	-2.0B
`cases`	166.2KB	166.2KB	+1.0B
`dataViewFieldEditor`	23.3KB	23.3KB	-2.0B
`discover`	27.9KB	27.9KB	-4.0B
`esUiShared`	152.4KB	152.4KB	-2.0B
`fileUpload`	7.2KB	7.2KB	-4.0B
`kbnUiSharedDeps-css`	313.2KB	313.2KB	-28.0B
`kbnUiSharedDeps-npmDll`	5.9MB	5.9MB	+1.2KB
`maps`	45.1KB	45.1KB	-2.0B
`savedObjectsFinder`	3.2KB	3.2KB	-2.0B
total			+1.1KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	400	404	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	480	484	+4
total			+6

History

💔 Build #127925 failed 8a6e647
💛 Build #127312 was flaky c06f8fa
💔 Build #127249 failed 2ba2c6f
💔 Build #127213 failed b93381e97c2972edb5e66913884a7af9510155aa
💔 Build #126979 failed 5351f8cea66ad4a5f213dafcfa47f292a03212fe
💔 Build #126747 failed 4ce163a42fab6f2e9d5c08984e7929e76ff6311a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This reverts commit b9ea4ce.

## Summary `[email protected]` ⏩ `[email protected]` 🦴 The primary changes in this upgrade are around the deprecated `EuiLoadingContent` being removed in favor of `EuiSkeletonText`. - Most instances have been a [direct swap of usage](327626a), but [some replacements were a bit more opinionated](e6ceb36) as I saw them as potential to take advantage of `EuiSkeletonText`'s syntactical sugar and screen reader announcements for when state switches to loaded. --- ## [`79.0.1`](https://github.com/elastic/eui/tree/v79.0.1) **Bug fixes** - Fixed broken push `EuiFlyout` behavior ([#6764](elastic/eui#6764)) ## [`79.0.0`](https://github.com/elastic/eui/tree/v79.0.0) - Updated all `EuiSkeleton` components with new props that allow for more control over screen reader live announcements: `announceLoadingStatus`, `announceLoadedStatus`, and `ariaLiveProps` ([#6752](elastic/eui#6752)) - Improved keyboard accessibility in `EuiPageHeader` by ensuring the right side menu items come into focus from left to right. ([#6753](elastic/eui#6753)) **Breaking changes** - Removed deprecated `EuiLoadingContent`. Use the `EuiSkeleton` components instead. ([#6754](elastic/eui#6754)) ## [`78.0.0`](https://github.com/elastic/eui/tree/v78.0.0) - Improved the contrast ratio of `EuiCheckbox`, `EuiRadio`, and `EuiSwitch` in their unchecked states to meet WCAG AA guidelines. ([#6729](elastic/eui#6729)) - Added React Testing Library `*ByTestSubject` custom commands to `within()`. RTL utilities can be imported from `@elastic/eui/lib/test/rtl`. ([#6737](elastic/eui#6737)) - Updated `EuiAvatar` to support a new letter `casing` prop that allow customizing text capitalization ([#6739](elastic/eui#6739)) - Updated `EuiFocusTrap` to support the `gapMode` prop configuration (now defaults to `padding`) ([#6744](elastic/eui#6744)) **Bug fixes** - Fixed inconsistency in `EuiSearchBar`'s AND/OR semantics between DSL and query string generation ([#6717](elastic/eui#6717)) - Fixed `EuiFieldNumber`'s native browser validity detection causing extra unnecessary rerenders ([#6741](elastic/eui#6741)) - Fixed the `scrollLock` property on `EuiFocusTrap` (and other components using `EuiFocusTrap`, such as `EuiFlyout` and `EuiModal`) to no longer block scrolling on nested portalled content, such as combobox dropdowns ([#6744](elastic/eui#6744)) **Breaking changes** - `EuiAvatar`s with the default `user` type will now default to capitalizing all initials in uppercase ([#6739](elastic/eui#6739)) --------- Co-authored-by: Kibana Machine <[email protected]>

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.9.0 labels May 5, 2023

cee-chen changed the title ~~Upgrade EUI v78.0.0~~ Upgrade EUI to v78.0.0 May 5, 2023

cee-chen changed the title ~~Upgrade EUI to v78.0.0~~ Upgrade EUI to v79.0.0 May 9, 2023

cee-chen force-pushed the eui-v78.0.x branch 2 times, most recently from 643e36b to c2f4824 Compare May 9, 2023 23:20

cee-chen changed the title ~~Upgrade EUI to v79.0.0~~ Upgrade EUI to v79.0.1 May 10, 2023

cee-chen mentioned this pull request May 10, 2023

[Synthetics] Overview page flyouts no longer compress cards to fit #157180

Closed

cee-chen force-pushed the eui-v78.0.x branch from 4ce163a to 5351f8c Compare May 10, 2023 20:10

cee-chen added 11 commits May 11, 2023 09:35

Upgrade EUI v78.0.0

38a7c08

EuiAvatar snapshot updates

265004f

Upgrade to EUI v79.0.0

1b02347

Convert basic usage of EuiLoadingContent to EuiSkeletonText

327626a

Convert examples using EuiSkeletonTexts isLoading API/wrapper

e6ceb36

- using this API has improved screen reader accessibility + announcements on load

Convert (assumed) loading titles to EuiSkeletonTitle

88a0293

Convert custom height/width single line text to EuiSkeletonRectangle

5ce9824

Remove euiLoadingContent selector/style override

1337dd1

- new EuiSkeletonText CSS should not have any margin-bottom to unset

Update EuiPageHeader snapshots

3f5541e

Upgrade to EUI v79.0.1 for flyout push fix

44a3e63

Fix FTR tests to account for new EuiPageHeader DOM order

041b5c0

cee-chen force-pushed the eui-v78.0.x branch from 5351f8c to b93381e Compare May 11, 2023 16:36

Harden flaky Security Cypress test

2ba2c6f

cee-chen force-pushed the eui-v78.0.x branch from b93381e to 2ba2c6f Compare May 11, 2023 18:30

Merge branch 'main' into eui-v78.0.x

c06f8fa

cee-chen marked this pull request as ready for review May 12, 2023 04:34

cee-chen requested a review from a team as a code owner May 12, 2023 04:34

jughosta approved these changes May 12, 2023

View reviewed changes

kc13greiner self-requested a review May 12, 2023 12:59

jbudz approved these changes May 12, 2023

View reviewed changes

nreese approved these changes May 12, 2023

View reviewed changes

kc13greiner approved these changes May 12, 2023

View reviewed changes

efegurkan approved these changes May 12, 2023

View reviewed changes

1Copenut reviewed May 12, 2023

View reviewed changes

stephmilovic approved these changes May 12, 2023

View reviewed changes

dominiqueclarke approved these changes May 12, 2023

View reviewed changes

spong approved these changes May 12, 2023

View reviewed changes

tsullivan approved these changes May 12, 2023

View reviewed changes

YulNaumenko approved these changes May 13, 2023

View reviewed changes

cnasikas approved these changes May 13, 2023

View reviewed changes

xcrzx approved these changes May 15, 2023

View reviewed changes

mohamedhamed-ahmed approved these changes May 15, 2023

View reviewed changes

jcger approved these changes May 15, 2023

View reviewed changes

ogupte approved these changes May 15, 2023

View reviewed changes

Merge branch 'main' into eui-v78.0.x

8a6e647

peteharverson approved these changes May 15, 2023

View reviewed changes

Merge branch 'main' into eui-v78.0.x

47cf567

jbudz merged commit b9ea4ce into elastic:main May 15, 2023

kibanamachine added the backport:skip This commit does not require backporting label May 15, 2023

cee-chen deleted the eui-v78.0.x branch May 15, 2023 21:16

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 16, 2023

Revert "Upgrade EUI to v79.0.1 (elastic#156925)"

10e974d

This reverts commit b9ea4ce.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v79.0.1 #156925

Upgrade EUI to v79.0.1 #156925

cee-chen commented May 5, 2023 •

edited

Loading

JasonStoltz commented May 9, 2023 •

edited

Loading

cee-chen commented May 9, 2023

cee-chen commented May 12, 2023

jughosta left a comment

nreese left a comment

kc13greiner left a comment

efegurkan left a comment

1Copenut left a comment

stephmilovic left a comment

dominiqueclarke left a comment

spong left a comment

tsullivan left a comment

YulNaumenko left a comment

cnasikas left a comment

xcrzx left a comment

mohamedhamed-ahmed left a comment

ogupte left a comment

cee-chen commented May 15, 2023

cee-chen commented May 15, 2023

peteharverson left a comment

peteharverson left a comment

cee-chen commented May 15, 2023

kibana-ci commented May 15, 2023

ESLint disabled line counts

Total ESLint disabled count

Upgrade EUI to v79.0.1 #156925

Upgrade EUI to v79.0.1 #156925

Conversation

cee-chen commented May 5, 2023 • edited Loading

Summary

79.0.1

79.0.0

78.0.0

JasonStoltz commented May 9, 2023 • edited Loading

cee-chen commented May 9, 2023

cee-chen commented May 12, 2023

jughosta left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

kc13greiner left a comment

Choose a reason for hiding this comment

efegurkan left a comment

Choose a reason for hiding this comment

1Copenut left a comment

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

dominiqueclarke left a comment

Choose a reason for hiding this comment

spong left a comment

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

xcrzx left a comment

Choose a reason for hiding this comment

mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

ogupte left a comment

Choose a reason for hiding this comment

cee-chen commented May 15, 2023

cee-chen commented May 15, 2023

peteharverson left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

cee-chen commented May 15, 2023

kibana-ci commented May 15, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

cee-chen commented May 5, 2023 •

edited

Loading

`79.0.1`

`79.0.0`

`78.0.0`

JasonStoltz commented May 9, 2023 •

edited

Loading