Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v74.1.0 #150235

Merged
merged 9 commits into from
Feb 9, 2023
Merged

Upgrade EUI to v74.1.0 #150235

merged 9 commits into from
Feb 9, 2023

Conversation

JasonStoltz
Copy link
Member

Summary

[email protected] ⏩ [email protected]

74.1.0

  • Added new EuiSkeletonText, EuiSkeletonTitle, EuiSkeletonCircle, and EuiSkeletonRectangle components (#6502)
  • Updated EuiSuperSelect screen reader instructions to be more specific (#6549)
  • Added error and updated alert glyphs to EuiIcon (#6550)
  • All EuiSkeleton components now accept an isLoading flag and children, which automatically handles conditionally rendering loading skeletons vs. loaded content (children) (#6562)
  • All EuiSkeleton components now accept a contentAriaLabel prop, which more meaningfully describes the loaded content to screen readers (#6562)
  • Updated EuiPopover screen reader instructions for mobile and click behaviors (#6567)

Bug fixes

  • Fixed EuiCard to ensure onClick method only runs once when title contains a React node (#6551)

Deprecations

  • Deprecated EuiLoadingContent - use EuiSkeletonText instead (#6557)

@JasonStoltz JasonStoltz added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 backport:skip This commit does not require backporting labels Feb 7, 2023
@cee-chen cee-chen added the EUI label Feb 7, 2023
@JasonStoltz JasonStoltz marked this pull request as ready for review February 7, 2023 19:17
@JasonStoltz JasonStoltz requested review from a team as code owners February 7, 2023 19:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Heenawter
Heenawter approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner review - snapshot changes LGTM 👍

jgowdyelastic
jgowdyelastic approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

nkhristinin
nkhristinin approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security solution platform LGTM!

@cee-chen
Copy link
Member

cee-chen commented Feb 9, 2023

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner February 9, 2023 16:58
@cee-chen cee-chen enabled auto-merge (squash) February 9, 2023 17:02
@cee-chen
Copy link
Member

cee-chen commented Feb 9, 2023

@elasticmachine merge upstream

@cee-chen cee-chen merged commit 20a9a01 into elastic:main Feb 9, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB +244.0B
visTypeVega 1.8MB 1.8MB +244.0B
total +488.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 348.5KB 348.9KB +415.0B
kbnUiSharedDeps-npmDll 5.3MB 5.4MB +8.6KB
total +9.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 10, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
a9b2e06 
* main: (115 commits)
  [Custom branding] Add custom logo to space selector (elastic#150284)
  [api-docs] 2023-02-10 Daily api_docs build (elastic#150831)
  [ci] build next docs in PRs when relevant files change (elastic#149991)
  [codeowners] allow overrides to take higher precedence (elastic#150821)
  [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788)
  [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780)
  [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761)
  fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768)
  [Synthetics] adjust overview scrolling e2e (elastic#150774)
  [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765)
  Upgrade EUI to v74.1.0 (elastic#150235)
  [skip ci] Fix labeling for Infrastructure UI (elastic#150571)
  [Enterprise Search] Move pipelines modal to flyout (elastic#150727)
  [Security Solution] fix flaky endpoint tests (elastic#150652)
  Fixes the space selector page layout  (elastic#150503)
  [Dashboard] [Navigation] Fix mount point bug (elastic#150507)
  [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685)
  [Dashboard Usability] Moves scrollbar to panel section (elastic#145628)
  [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497)
  [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394)
  ...
@JasonStoltz JasonStoltz deleted the eui-v74.1.x branch February 10, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@Heenawter Heenawter Heenawter approved these changes

@nkhristinin nkhristinin nkhristinin approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.