Fix bundle bloat -- utility being imported from main app module.

x-pack/plugins/ml/public/application/app.tsx

@@ -10,9 +10,7 @@ import './_index.scss';
 import ReactDOM from 'react-dom';
 import { pick } from 'lodash';
 
-import type { DataViewsContract } from '@kbn/data-views-plugin/public';
-import type { AppMountParameters, CoreStart, HttpStart } from '@kbn/core/public';
-import type { UsageCollectionSetup } from '@kbn/usage-collection-plugin/public';
+import type { AppMountParameters, CoreStart } from '@kbn/core/public';
 import { DatePickerContextProvider, type DatePickerDependencies } from '@kbn/ml-date-picker';
 import { Storage } from '@kbn/kibana-utils-plugin/public';
 import { UI_SETTINGS } from '@kbn/data-plugin/common';
@@ -21,21 +19,15 @@ import { StorageContextProvider } from '@kbn/ml-local-storage';
 import useLifecycles from 'react-use/lib/useLifecycles';
 import useObservable from 'react-use/lib/useObservable';
 import type { MlFeatures } from '../../common/constants/app';
-import { MlLicense } from '../../common/license';
-import { MlCapabilitiesService } from './capabilities/check_capabilities';
 import { ML_STORAGE_KEYS } from '../../common/types/storage';
 import type { MlSetupDependencies, MlStartDependencies } from '../plugin';
 import { clearCache, setDependencyCache } from './util/dependency_cache';
 import { setLicenseCache } from './license';
-import { mlUsageCollectionProvider } from './services/usage_collection';
 import { MlRouter } from './routing';
-import { mlApiServicesProvider } from './services/ml_api_service';
-import { HttpService } from './services/http_service';
 import type { PageDependencies } from './routing/router';
 import { EnabledFeaturesContextProvider } from './contexts/ml';
 import type { StartServices } from './contexts/kibana';
-import { fieldFormatServiceFactory } from './services/field_format_service_factory';
-import { indexServiceFactory } from './util/index_service';
+import { getMlGlobalServices } from './util/get_services';
 
 export type MlDependencies = Omit<
   MlSetupDependencies,
@@ -53,38 +45,6 @@ interface AppProps {
 
 const localStorage = new Storage(window.localStorage);
 
-/**
- * Provides global services available across the entire ML app.
- */
-export function getMlGlobalServices(
-  httpStart: HttpStart,
-  dataViews: DataViewsContract,
-  usageCollection?: UsageCollectionSetup
-) {
-  const httpService = new HttpService(httpStart);
-  const mlApiServices = mlApiServicesProvider(httpService);
-  // Note on the following services:
-  // - `mlIndexUtils` is just instantiated here to be passed on to `mlFieldFormatService`,
-  //   but it's not being made available as part of global services. Since it's just
-  //   some stateless utils `useMlIndexUtils()` should be used from within components.
-  // - `mlFieldFormatService` is a stateful legacy service that relied on "dependency cache",
-  //   so because of its own state it needs to be made available as a global service.
-  //   In the long run we should again try to get rid of it here and make it available via
-  //   its own context or possibly without having a singleton like state at all, since the
-  //   way this manages its own state right now doesn't consider React component lifecycles.
-  const mlIndexUtils = indexServiceFactory(dataViews);
-  const mlFieldFormatService = fieldFormatServiceFactory(mlApiServices, mlIndexUtils);
-
-  return {
-    httpService,
-    mlApiServices,
-    mlFieldFormatService,
-    mlUsageCollection: mlUsageCollectionProvider(usageCollection),
-    mlCapabilities: new MlCapabilitiesService(mlApiServices),
-    mlLicense: new MlLicense(),
-  };
-}
-
 export interface MlServicesContext {
   mlServices: MlGlobalServices;
 }

x-pack/plugins/ml/public/application/management/jobs_list/components/jobs_list_page/jobs_list_page.tsx

@@ -28,6 +28,7 @@ import { RedirectAppLinks } from '@kbn/shared-ux-link-redirect-app';
 import type { SharePluginStart } from '@kbn/share-plugin/public';
 import type { SpacesContextProps, SpacesPluginStart } from '@kbn/spaces-plugin/public';
 import type { FieldFormatsStart } from '@kbn/field-formats-plugin/public';
+import { getMlGlobalServices } from '../../../../util/get_services';
 import { EnabledFeaturesContextProvider } from '../../../../contexts/ml';
 import { type MlFeatures, PLUGIN_ID } from '../../../../../../common/constants/app';
 
@@ -36,7 +37,6 @@ import { checkGetManagementMlJobsResolver } from '../../../../capabilities/check
 import { AccessDeniedPage } from '../access_denied_page';
 import { InsufficientLicensePage } from '../insufficient_license_page';
 import { JobSpacesSyncFlyout } from '../../../../components/job_spaces_sync';
-import { getMlGlobalServices } from '../../../../app';
 import { ExportJobsFlyout, ImportJobsFlyout } from '../../../../components/import_export_jobs';
 import type { MlSavedObjectType } from '../../../../../../common/types/saved_objects';
 

x-pack/plugins/ml/public/application/util/get_services.ts

@@ -0,0 +1,51 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type { HttpStart } from '@kbn/core-http-browser';
+
+import type { DataViewsContract } from '@kbn/data-views-plugin/public';
+import type { UsageCollectionSetup } from '@kbn/usage-collection-plugin/public';
+
+import { MlLicense } from '../../../common/license';
+import { MlCapabilitiesService } from '../capabilities/check_capabilities';
+import { fieldFormatServiceFactory } from '../services/field_format_service_factory';
+import { HttpService } from '../services/http_service';
+import { mlApiServicesProvider } from '../services/ml_api_service';
+import { mlUsageCollectionProvider } from '../services/usage_collection';
+import { indexServiceFactory } from './index_service';
+
+/**
+ * Provides global services available across the entire ML app.
+ */
+export function getMlGlobalServices(
+  httpStart: HttpStart,
+  dataViews: DataViewsContract,
+  usageCollection?: UsageCollectionSetup
+) {
+  const httpService = new HttpService(httpStart);
+  const mlApiServices = mlApiServicesProvider(httpService);
+  // Note on the following services:
+  // - `mlIndexUtils` is just instantiated here to be passed on to `mlFieldFormatService`,
+  //   but it's not being made available as part of global services. Since it's just
+  //   some stateless utils `useMlIndexUtils()` should be used from within components.
+  // - `mlFieldFormatService` is a stateful legacy service that relied on "dependency cache",
+  //   so because of its own state it needs to be made available as a global service.
+  //   In the long run we should again try to get rid of it here and make it available via
+  //   its own context or possibly without having a singleton like state at all, since the
+  //   way this manages its own state right now doesn't consider React component lifecycles.
+  const mlIndexUtils = indexServiceFactory(dataViews);
+  const mlFieldFormatService = fieldFormatServiceFactory(mlApiServices, mlIndexUtils);
+
+  return {
+    httpService,
+    mlApiServices,
+    mlFieldFormatService,
+    mlUsageCollection: mlUsageCollectionProvider(usageCollection),
+    mlCapabilities: new MlCapabilitiesService(mlApiServices),
+    mlLicense: new MlLicense(),
+  };
+}

x-pack/plugins/ml/public/embeddables/common/resolve_job_selection.tsx

@@ -13,9 +13,9 @@ import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
 import { toMountPoint } from '@kbn/react-kibana-mount';
 import type { DataViewsContract } from '@kbn/data-views-plugin/public';
 import { getInitialGroupsMap } from '../../application/components/job_selector/job_selector';
-import { getMlGlobalServices } from '../../application/app';
 import type { JobId } from '../../../common/types/anomaly_detection_jobs';
 import { JobSelectorFlyout } from './components/job_selector_flyout';
+import { getMlGlobalServices } from '../../application/util/get_services';
 
 /**
  * Handles Anomaly detection jobs selection by a user.

x-pack/plugins/ml/public/embeddables/job_creation/common/create_flyout.tsx

@@ -15,8 +15,7 @@ import type { DataPublicPluginStart } from '@kbn/data-plugin/public';
 import type { CoreStart } from '@kbn/core/public';
 import type { LensPublicStart } from '@kbn/lens-plugin/public';
 import type { DashboardStart } from '@kbn/dashboard-plugin/public';
-
-import { getMlGlobalServices } from '../../../application/app';
+import { getMlGlobalServices } from '../../../application/util/get_services';
 
 export interface FlyoutComponentProps {
   onClose: () => void;

x-pack/plugins/ml/public/register_helper/index.ts

@@ -6,7 +6,6 @@
  */
 
 export { registerEmbeddables } from '../embeddables';
-export { registerManagementSection } from '../application/management';
 export { registerMlUiActions } from '../ui_actions';
 export { registerSearchLinks } from './register_search_links';
 export { registerMlAlerts } from '../alerting';