-
Notifications
You must be signed in to change notification settings - Fork 499
Update unique keys for latest issues transform to catch all updates #15700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a refactor; it changes behaviour. Can we have a clearer title to explain what is being done?
… unique keys transformation
I’ve updated the title and PR description, and changed the version from 2.18.0 to 2.17.1. Initially, I thought this was a breaking change. However, since the transform is deleted and recreated, it’s not a breaking change after all. @efd6, could you please review? Thanks. |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
💚 Build Succeeded
History
|
Proposed commit message
This pull request updates the configuration for the GitHub issues Elasticsearch transform to improve how the latest state of issues is tracked and stored. The main focus is on making the transform more robust by using more reliable unique keys and bumping the transform version.
The previous transform wasn't taking into account all updates (e.g. adding a label to an issue). Since the field
github.issues.updated_at
changes each time the issue is updated, this field covers more use cases that the initialgithub.issues.created_at
field. I've also changed the unique issue identifier from url togithub.issues.id
.Key changes:
Transform logic improvements:
unique_key
fields inlatest_issues/transform.yml
to usegithub.issues.id
andgithub.issues.updated_at
instead of repository and URL fields. This ensures that the transform identifies the latest issue state more reliably and efficiently.Versioning:
_meta.fleet_transform_version
from1.0.0
to2.0.0
to indicate a breaking change and trigger reinstallation and restart of the transform.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots