Add GetPerformanceInfo #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strawgate
force-pushed
the
add_get_perf_info
branch
from
2bc2675 to
4d46e16
Compare
andrewkroh
reviewed
Aug 20, 2025
Member
andrewkroh
left a comment
andrewkroh
left a comment
There was a problem hiding this comment.
Overall looks good to me, just minor requests.
andrewkroh
reviewed
Aug 20, 2025
Contributor
Author
|
relies on #39 |
strawgate
force-pushed
the
add_get_perf_info
branch
from
6ddab40 to
0f132ac
Compare
andrewkroh
reviewed
Aug 21, 2025
| // https://learn.microsoft.com/en-us/windows/win32/api/psapi/nf-psapi-getperformanceinfo | ||
| func GetPerformanceInfo() (PerformanceInformation, error) { | ||
| var pi PerformanceInformation | ||
| pi.CB = uint32(unsafe.Sizeof(pi)) |
Member
There was a problem hiding this comment.
CB usages need updated to cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GetPerformanceInfo
and update (fool me once, shame on you, fool me twice shame on me) readme to mention that syscalls are generated with go generate and a comment