fix: Notify items if an error occurs in bulk indexer #615
+156
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
@Anaethelion (as last main contributor) would you mind taking a look at this PR when you get a chance? #179 has been going on for a long time and prevents from using the bulk indexer in many production use-cases where visibility into failed writes is needed. |
* makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err`
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
Hi all, I've added some tests to cover the new behaviour, with a slight refactor to make the code more DRY and a minor bug fix. This will be sorted soon, thank you for your patience and for your contribution! |
MattDevy
changed the title
elastic-vault-github-plugin-prod bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <[email protected]> (cherry picked from commit 6ea4a8a)
elastic-vault-github-plugin-prod bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <[email protected]> (cherry picked from commit 6ea4a8a)
elastic-vault-github-plugin-prod bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <[email protected]> (cherry picked from commit 6ea4a8a)
MattDevy
added a commit
that referenced
this pull request
Nov 25, 2025
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <[email protected]> (cherry picked from commit 6ea4a8a)
MattDevy
added a commit
that referenced
this pull request
Nov 25, 2025
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <[email protected]> (cherry picked from commit 6ea4a8a)
MattDevy
added a commit
that referenced
this pull request
Nov 25, 2025
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <[email protected]> (cherry picked from commit 6ea4a8a)
MattDevy
added a commit
that referenced
this pull request
Nov 25, 2025
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <[email protected]> (cherry picked from commit 6ea4a8a)
MattDevy
added a commit
that referenced
this pull request
Nov 25, 2025
fix: Notify items if an error occurs in bulk indexer (#615) * notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- (cherry picked from commit 6ea4a8a) Co-authored-by: ansssu <[email protected]> Co-authored-by: Matt Devy <[email protected]>
MattDevy
added a commit
that referenced
this pull request
Nov 25, 2025
fix: Notify items if an error occurs in bulk indexer (#615) * notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- (cherry picked from commit 6ea4a8a) Co-authored-by: ansssu <[email protected]> Co-authored-by: Matt Devy <[email protected]>
MattDevy
added a commit
that referenced
this pull request
Nov 25, 2025
fix: Notify items if an error occurs in bulk indexer (#615) * notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- (cherry picked from commit 6ea4a8a) Co-authored-by: ansssu <[email protected]> Co-authored-by: Matt Devy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate errors on items. Fix #179