Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Fix theme package builds #8120

Merged

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Nov 6, 2024

Summary

This PR updates the builds for the new theme packages that ensure Kibana CI runs as expected:

  • ensure core-js polyfills are handled as expected
  • align eui-theme-borealis package build with eui-theme-common build to ensure both esm and cjs packages are available

QA

  • CI builds
  • Kibana CI doesn't run into errors of missing modules or import statements (before, after)

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I'm approving it now but let me know if there are any additional changes

@mgadewoll
Copy link
Contributor Author

mgadewoll commented Nov 7, 2024

The changes look good. I'm approving it now but let me know if there are any additional changes

Sure! I realized I forgot to remove "Draft" state 😅
I'll merge this PR first and will need to rebase this one after as they touch similar code around the build script.

@mgadewoll mgadewoll marked this pull request as ready for review November 7, 2024 11:54
@mgadewoll mgadewoll requested a review from a team as a code owner November 7, 2024 11:54
@mgadewoll mgadewoll merged commit 7a5913d into elastic:eui-theme/borealis Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants