-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual Refresh] Setup semantic color tokens #8097
Merged
mgadewoll
merged 36 commits into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/125-126-semantic-color-tokens
Oct 31, 2024
Merged
[Visual Refresh] Setup semantic color tokens #8097
mgadewoll
merged 36 commits into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/125-126-semantic-color-tokens
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
eui-theme/125-126-semantic-color-tokens
branch
from
October 24, 2024 07:26
311817a
to
641159f
Compare
move temp transparent backgrounds to temporary component tokens
…transparent colors to use new transparent colors
- move form specific tokens to themes
mgadewoll
force-pushed
the
eui-theme/125-126-semantic-color-tokens
branch
from
October 25, 2024 08:04
1beabf2
to
c980206
Compare
tkajtoch
reviewed
Oct 31, 2024
tkajtoch
reviewed
Oct 31, 2024
packages/eui-theme-borealis/src/variables/colors/_primitive_colors.ts
Outdated
Show resolved
Hide resolved
tkajtoch
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great. Considering it's targetting a feature branch I don't have any objections
ensure only tests in src are run
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
I'm happy with the latest changes. LGTM! |
tkajtoch
pushed a commit
that referenced
this pull request
Oct 31, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes https://github.com/elastic/eui-private/issues/125
closes https://github.com/elastic/eui-private/issues/126
This PR implements the base setup for colors tokens. The main idea is to remove our dependency on color calculations and use direct token values instead. To ensure this works in both themes we lift the old color calculations up to the theme definitions level.
Additionally all existing tokens are kept to ensure backwards compatibility and the values were updated for the new theme to match expected output.
The token naming is mapped to variables in Figma.
The implemented theme structure:
The
colors
key now holds a lot more color tokens. These new tokens are (grouped):primary10
andshade10
)The
components
key contains:buttons
key which holds button specific tokensforms
key which holds form specific tokensChanges
components
key on the EuiTheme and adds component specific color tokensshade
andtint
andtransparentize
(where possible and/or necessary at this time) by adding tokens insteadeuiBackgroundColor
,euiBorderColor
,euiButtonColor
,euiButtonFilledColor
andeuiButtonEmptyColor
to return tokensaccentSecondary
(currently enabled as background color)accentSecondary
to relevant componentsImportant
This update does not include an update to the static JSON token files.
QA