[EuiResizableButton] Add new prop to allow consumers to account for overlap with scrollbars #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
commented
Sep 12, 2024
| * This can occasionally occlude interactive elements like scrollbars. To prevent | ||
| * this overlap, use this prop to remove the overlap for the specified side. | ||
| */ | ||
| accountForScrollbars?: 'before' | 'after' | 'both'; |
There was a problem hiding this comment.
Very open to feedback on this prop name/API - I'm not 100% sold on it or anything but it was the best I could come up with 😅
There was a problem hiding this comment.
Hmm, yeah it's kind of very specific but at the same time it might be not clear enough otherwise ...
Maybe accountForOverlap? 🤔
There was a problem hiding this comment.
I'm going to opt to merge this in as-is if that's okay! Overlap also feels a little vague to me, at least Scrollbars hints as to the purpose of the prop? 😅
Merged
9 tasks
💚 Build Succeeded
|
mgadewoll
approved these changes
Sep 16, 2024
| * This can occasionally occlude interactive elements like scrollbars. To prevent | ||
| * this overlap, use this prop to remove the overlap for the specified side. | ||
| */ | ||
| accountForScrollbars?: 'before' | 'after' | 'both'; |
There was a problem hiding this comment.
Hmm, yeah it's kind of very specific but at the same time it might be not clear enough otherwise ...
Maybe accountForOverlap? 🤔
MichaelMarcialis
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #8010 (comment) and #7988
This PR adds the
accountForScrollbarsprop to EuiResizableButton, which allows consumers to conditionally remove the negative margins behavior on the button if it causes the button to block scrollbars.QA
General checklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobileand screenreader modes@defaultif default values are missing) and playground toggles- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Updated visual regression tests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)