Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up copy/pasting of tabular content in EuiDataGrid and EuiBasic/InMemoryTable #8019

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Clean up copy/pasting of tabular content in EuiDataGrid and EuiBasic/InMemoryTable #8019

merged 14 commits into from
Sep 23, 2024

Commits on Sep 17, 2024

  1. [setup] Create new copy/ dir in services 

    and move existing `copy_to_clipboard` there
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    86d48a5 View commit details
    Browse the repository at this point in the history

  2. Create copy service

    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    dc87591 View commit details
    Browse the repository at this point in the history

  3. [EuiDataGrid] Set up copy markers for row cells

    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1b617a8 View commit details
    Browse the repository at this point in the history

  4. [EuiDataGrid] Set up copy markers for header columns/row 

    - requires waterfalling `visibleColCount` number down to header cell wrapper for isLastColumn logic
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f0b7d6e View commit details
    Browse the repository at this point in the history

  5. [EuiDataGrid] Fix footer rows not appending last/first column classes 

    - and as such not appending the correct copy markers
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8f1fd8b View commit details
    Browse the repository at this point in the history

  6. [EuiBasicTable] Set up copy markers for table cells 

    - requires adding an `append` prop to various cell components, for rendering this hidden text outside of the cell content wrapper
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8a3f6e1 View commit details
    Browse the repository at this point in the history

  7. Add E2E Cypress tests for checking final copied content 

    - my god this was a StackOverflow journey
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    44f9338 View commit details
    Browse the repository at this point in the history

  8. Fix failing Cypress test due to new copy marker DOM 

    - we should be more specific with selectors anyway
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7089f50 View commit details
    Browse the repository at this point in the history

  9. Fix bizarre typescript complaint 

    works just fine in actual browsers, but typescript really wants document for whatever reason

see https://stackoverflow.com/questions/74809554/cant-get-paste-event-to-work-in-typescript :|
    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fedb57d View commit details
    Browse the repository at this point in the history

  10. changelog

    @cee-chen
    cee-chen committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    729f192 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. [PR feedback] Use non-invisible characters to reduce likelihood of co… 

    …nsumer

+ use 2 characters for increased chances

+ add more `data` attributes to help identify usages
    @cee-chen
    cee-chen committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9a22861 View commit details
    Browse the repository at this point in the history

  2. Rename exported noCopy marker util 

    - in case consumers want to use it outside SR text - thanks Davis for the prompt!
    @cee-chen
    cee-chen committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1e749f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch 'main' into tabular-copying

    @cee-chen
    cee-chen authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5024aa8 View commit details
    Browse the repository at this point in the history

  2. sad prettier noises

    @cee-chen
    cee-chen authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    424cc63 View commit details
    Browse the repository at this point in the history