[Emotion] Convert EuiDataGrid gridStyles to Emotion (Part 3)
#8006
Commits on Sep 6, 2024
-
- unfortunately can't be as specific here, has to be applied to top level datagrid styles
-
Convert grid border style options to Emotion
- handle this at topmost grid level, I personally don't think it makes any sense to split it up by component when they affect each other - more files makes it harder to write/predict + clean up several CSS unsets by assuming lack of borders rather than presence of borders
-
Convert fontSize and cellPadding grid styles
- some fontSize/lineHeight tweaking required to stay the same as prod (due to changes Caroline made to euiFontSize) + improve Emotion className labeling
-
[tech debt] Address RowHeightUtils cell padding TODO
- we can now obtain cell padding sizes from dynamic themes, hooray
-
Convert header and footer row styles
- pass `gridStyles` down through the body and to the rows so CSS can be a bit flatter, as those styles only concern those components + convert enzyme tests to RTL
-
[docs] Tweak footer example to allow testing sticky CSS
+ remove unnecessary show footer toggle - it's the entire point of the demo, why would we disable it? + remove flex in favor of EuiSpacer
-
Fix clashing border CSS from gridStyle props
- grid borders and header/footer underline/overlines were conflicting with one another - borders on header/footer cells were adding extra height to the cells themselves (unlike regular row cells)
-
-
-
-
[storybook] update toolbar stories to dogfood new datagrid storybook …
…utils - VRT stories should use minimal data still for screenshot simplicity + add 2 new stories with more customizable controls, which lists the nested props documentation for each nested config
-
-
-
[storybook] Move row height stories to their own file/subdir
- allows us to expand props documentation & use controls for `rowHeightsOptions` + add test for lineHeight
-
-
Fix
falseobj values not showing up in code snippet+ remove `PRESERVED_FALSE_VALUE_PROPS` logic - we should let the defaultProps logic handle that instead and always show `false` props if they're non-defaults (testable on, e.g. `<EuiExpression uppercase={false} />`) -
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.