[Tech debt] Create new internal util for rendering semantic <a>/<button> elements
#7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
link-or-button
branch
from
aa22fce
to
c2c3a88
Compare
- all logic is related to links, and I'm shortly about to add some DRY logic that is link adjacent but not security adjacent that will use these utils, so it feels like it makes sense to group them all together
- and update component imports
- gets slightly messed by the new component, we need to semi-brute-force it
+ migrate Enzyme tests
cee-chen
force-pushed
the
link-or-button
branch
from
c2c3a88
to
936b098
Compare
- the component will now automatically detect this
cee-chen
force-pushed
the
link-or-button
branch
from
936b098
to
3d3453d
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
🙈 Still working on this, I want to pick it back up after the Emotion meta |
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
Someday...... |
|
Closing, won't have time to finish this sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a setup PR.
NOTE: No functional output DOM should have changed as a result of this PR, it's purely meant to DRY out repetitive logic and help clean up confusing types as a result.
QA
General checklist
- [ ] Checked for accessibility including keyboard-only and screenreader modes