Add sparkles glyph to EuiIcon #6897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeairns
force-pushed
the
rk/add-stardust-glyph
branch
from
edea49e
to
d3ce0a6
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6897/ |
|
It appears there are a couple of failing tests for |
|
Thanks for catching that Ryan 🙇 should be fixed now, please go ahead and sync latest main into this branch! Code LGTM, I'm a little curious about the icon name though - is there a particular reason for |
ryankeairns
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6897/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6875
Summary
Add
sparklesglyph toEuiIconFigma
Docs
QA
General checklist
- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs (using@defaultif default values are missing) and playground toggles- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes