Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo Enterprise Search to EuiIcon #3066

Merged
merged 5 commits into from
Mar 13, 2020

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Mar 13, 2020

Summary

Closes #2937

The logoEnterpriseSearch was previously renamed to logoWorkplaceSearch to match the product rename. And there's a deprecation scheduled on #1469:

  • EuiIcon's logoEnterpriseSearch type deprecated in favor of logoWorkplaceSearch

But there's the necessity of adding a new logoEnterpriseSearch to match the solution (which encompasses the workplace search, app search, and site search products).

In this PR I'm adding the new logo.

Figma Design

Screenshot 2020-03-13 at 17 56 41

Light and Dark themes

icons-themes@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu
Copy link
Contributor Author

@snide, should we remove the deprecation schedule on #1469?

@miukimiu miukimiu requested review from snide and cchaos March 13, 2020 18:32
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3066/

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Remove the deprecation warning.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh wait, I think we need a changelog too

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3066/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Enterprise Search logo in library
4 participants