-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo Enterprise Search to EuiIcon #3066
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_3066/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Remove the deprecation warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh wait, I think we need a changelog too
Preview documentation changes for this PR: https://eui.elastic.co/pr_3066/ |
Summary
Closes #2937
The
logoEnterpriseSearch
was previously renamed tologoWorkplaceSearch
to match the product rename. And there's a deprecation scheduled on #1469:logoEnterpriseSearch
type deprecated in favor oflogoWorkplaceSearch
But there's the necessity of adding a new
logoEnterpriseSearch
to match the solution (which encompasses the workplace search, app search, and site search products).In this PR I'm adding the new logo.
Figma Design
Light and Dark themes
Checklist
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes