-
Notifications
You must be signed in to change notification settings - Fork 115
Add private capabilities API #5741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure, but I'm wondering if this also supports a failures field as a list of exceptions. https://github.com/elastic/elasticsearch/blob/4c1c51e87001f4df27667ad23e40729071646faa/server/src/main/java/org/elasticsearch/action/support/nodes/BaseNodesResponse.java#L98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? I haven't been able to find the toXContent() code. I've added failures. Not too worried, since it's a private API.
|
|
||
| export class FailedNodeException { | ||
| node_id: Id | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier needs running for formatting, otherwise LGTM!
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5741-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a245ec050696cdb7ff00a3b887e7ec31afc57183
# Push it to GitHub
git push --set-upstream origin backport-5741-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
* Add private capabilities API * Add failures * Run make spec-format-fix (cherry picked from commit a245ec0)
* Add private capabilities API * Add failures * Run make spec-format-fix (cherry picked from commit a245ec0)
* Add private capabilities API * Add failures * Run make spec-format-fix (cherry picked from commit a245ec0) # Conflicts: # specification/_doc_ids/table.csv
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
For rest-api-spec generation purposes. Resources: