Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 24, 2025

This PR updates the DOCS_BRANCHi in the Makefile so that the appropriate URLs are generated.
I noticed it was still linking to "8.x" URLs in #5339

@lcawl lcawl requested a review from a team September 24, 2025 22:58
@lcawl lcawl marked this pull request as ready for review September 24, 2025 22:59
Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Note that the 8.19 branch still references 8.x in the overlays and some spec files.

docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/es-connectors-tutorial-api.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/data-streams.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/docs-replication.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/eql.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/esql.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/kibana/8.x/xpack-graph.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/index-lifecycle-management.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/logstash/8.x/logstash-centralized-pipeline-management.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/machine-learning/8.x/ml-ad-finding-anomalies.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/machine-learning/8.x/ml-dfa-overview.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/machine-learning/8.x/ml-nlp-overview.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/query-dsl-rule-query.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/modules-scripting.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/snapshot-restore.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/snapshots-take-snapshot.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/xpack-sql.html
docs/overlays/elasticsearch-shared-overlays.yaml:            url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/xpack-alerting.html
docs/overlays/elasticsearch-shared-overlays.yaml:        url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/field-and-document-access-control.html#templating-role-query
docs/overlays/elasticsearch-shared-overlays.yaml:          url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/query-dsl.html
docs/overlays/elasticsearch-shared-overlays.yaml:          url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/analysis-tokenizers.html
docs/overlays/elasticsearch-shared-overlays.yaml:          url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/query-dsl.html
docs/overlays/elasticsearch-shared-overlays.yaml:          url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/query-dsl.html
docs/overlays/elasticsearch-shared-overlays.yaml:        url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/collapse-search-results.html
docs/overlays/elasticsearch-shared-overlays.yaml:        url: https://www.elastic.co/guide/en/elasticsearch/reference/8.x/index-modules.html
specification/ilm/_types/Phase.ts:   * The freeze action is a noop in 8.x
specification/license/get/GetLicenseRequest.ts:     * This parameter is deprecated and will always be set to true in 8.x.

Should we update at least the overlays in this PR?

@lcawl
Copy link
Contributor Author

lcawl commented Sep 26, 2025

Should we update at least the overlays in this PR?

Good catch! I've updated the URLs in the overlay in 3f7648d

@lcawl lcawl merged commit 44822e9 into 8.19 Sep 26, 2025
7 checks passed
@lcawl lcawl deleted the 819-docsbranch branch September 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants