Skip to content

[ML] Add SageMaker #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2025
Merged

[ML] Add SageMaker #4940

merged 7 commits into from
Jul 28, 2025

Conversation

prwhelan
Copy link
Member

Create put request types, objects, and examples for SageMaker. Verified with make validate api=inference.put.

Create put request types, objects, and examples for SageMaker.
Verified with `make validate api=inference.put`.
/**
* Service Settings specific to the Elastic API for the Amazon SageMaker service.
*/
export class AmazonSageMakerElasticServiceSettings extends AmazonSageMakerServiceSettings {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I should delete this and roll it into the parent class - I don't see a lot of inheritance going on (and that's maybe a good thing) but it might look weird for TaskSettings because elastic can handle any input key/value pair

Copy link
Contributor

github-actions bot commented Jul 16, 2025

Following you can find the validation changes against the target branch for the API.

API Status Request Response
inference.put_amazonsagemaker 🟠 → ⚪ Missing type → Missing test Missing type → Missing test

You can validate this API yourself by using the make validate target.

@prwhelan prwhelan marked this pull request as ready for review July 22, 2025 13:28
endpoint_name: string
/**
* The API format to use when calling SageMaker.
* This will structure the payload when invoking the SageMaker endpoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm did you mean: This will be the structure of the payload...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? I don't know what I mean lol

I'm trying to say that we'll convert from the elastic payload that is sent during the inference request to the selected api and send that as the payload

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits, please take or leave them. We place the examples in an example > request folder so that the generator can find them. Would you mind putting the request folder into an example folder, please?

@szabosteve
Copy link
Contributor

@prwhelan Thank you for providing the docs and doing the update!
Wanted to mention that we place the examples in an example > request folder so that the generator can find them. Would you mind putting the request folder into an example folder, please?

@prwhelan
Copy link
Member Author

@prwhelan Thank you for providing the docs and doing the update! Wanted to mention that we place the examples in an example > request folder so that the generator can find them. Would you mind putting the request folder into an example folder, please?

Sorry! I missed this comment. Thank you for reiterating

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of the docs! LGTM!

@prwhelan prwhelan merged commit eee68f2 into main Jul 28, 2025
8 checks passed
@prwhelan prwhelan deleted the sagemaker branch July 28, 2025 12:32
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4940-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eee68f22a903901642052d77e5ab2b88902398bf
# Push it to GitHub
git push --set-upstream origin backport-4940-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-4940-to-8.19.

Copy link
Contributor

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-4940-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eee68f22a903901642052d77e5ab2b88902398bf
# Push it to GitHub
git push --set-upstream origin backport-4940-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-4940-to-9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants