Skip to content

[Openapi] Product metadata in extension #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2025
Merged

[Openapi] Product metadata in extension #4511

merged 6 commits into from
Jun 17, 2025

Conversation

l-trotta
Copy link
Contributor

Closes #4443

@l-trotta l-trotta requested a review from a team as a code owner June 10, 2025 14:57
@l-trotta l-trotta marked this pull request as draft June 10, 2025 14:57
@l-trotta l-trotta added the skip-backport This pull request should not be backported label Jun 10, 2025
@l-trotta
Copy link
Contributor Author

@georgewallace I have hardcoded the table that will be in a file just to output a quick preview, if the output is okay then I'll proceed with the implementation!

@georgewallace
Copy link

georgewallace commented Jun 10, 2025

Output looks good. Thanks @l-trotta
cc: @szabosteve

@l-trotta
Copy link
Contributor Author

l-trotta commented Jun 12, 2025

@swallez not sure about how to pass the file, should it be another cli input? or just a constant since it won't change? should I worry about file system separators? we've decided to hardcode it since it won't change

@l-trotta l-trotta marked this pull request as ready for review June 16, 2025 12:57
@l-trotta l-trotta added backport 9.0 and removed skip-backport This pull request should not be backported labels Jun 17, 2025
@l-trotta l-trotta merged commit 040e99d into main Jun 17, 2025
10 of 11 checks passed
@l-trotta l-trotta deleted the product-metadata branch June 17, 2025 10:42
Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4511-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 040e99de6b0a8876cd0d1c6f639ef91c29333345
# Push it to GitHub
git push --set-upstream origin backport-4511-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4511-to-9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Related product metadata per operation
3 participants