Skip to content

Several improvements to token filter types #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Several improvements to token filter types #4291

wants to merge 5 commits into from

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock commented Apr 17, 2025 •
edited
Loading

An issue on the JS repo was opened about a missing cjk_bigram token filter type. I did an audit of the token filter docs and found a few missing types, so I:

  • Added the missing types
  • Added some missing values to enums
  • Moved a couple types into their relevant plugin files
  • Created a few base types for token filters that share most of the same parameters
  • Added docstrings to as many parameters as I could find
  • Removed a few parameters not mentioned in the docs

Fixes #4251
Fixes elastic/elasticsearch-js#2726

@JoshMock JoshMock enabled auto-merge (squash) April 17, 2025 18:42
@JoshMock JoshMock requested review from pquentin, l-trotta and a team April 17, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin Awaiting requested review from pquentin

@l-trotta l-trotta Awaiting requested review from l-trotta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport 8.x backport 8.18 backport 9.0 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several missing token filter types TypescriptError: Missing filter type cjk_bigram
1 participant
@JoshMock