Skip to content

Output the public API only in the stack OpenAPI schema #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

swallez
Copy link
Member

@swallez swallez commented Dec 13, 2024

Keep only public items in the stack OpenAPI export

Fixes #3300

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

clients_schema::Flavor::Stack.available(a)
?

We should probably keep these two in sync.

@swallez
Copy link
Member Author

swallez commented Dec 13, 2024

We should probably keep these two in sync.

Good catch. I have refactored the code so that the filtering is done in a single location.

@Anaethelion Anaethelion force-pushed the fix-private-visibility branch from 9c10107 to d7689a7 Compare April 23, 2025 16:34
@Anaethelion Anaethelion merged commit bd35837 into main Apr 23, 2025
13 checks passed
@Anaethelion Anaethelion deleted the fix-private-visibility branch April 23, 2025 16:44
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3308-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd35837b4c1d3aa9cfdbe3710350241526b41e72
# Push it to GitHub
git push --set-upstream origin backport-3308-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3308-to-8.x.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3308-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd35837b4c1d3aa9cfdbe3710350241526b41e72
# Push it to GitHub
git push --set-upstream origin backport-3308-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3308-to-8.18.

github-actions bot pushed a commit that referenced this pull request Apr 23, 2025
* Output the public API only in the stack OpenAPI schema

* Fix comment

* Refactor OpenAPI conversion to define filters in a single place

(cherry picked from commit bd35837)
Anaethelion pushed a commit that referenced this pull request Apr 23, 2025
* Output the public API only in the stack OpenAPI schema

* Fix comment

* Refactor OpenAPI conversion to define filters in a single place

(cherry picked from commit bd35837)

Co-authored-by: Sylvain Wallez <[email protected]>
Anaethelion pushed a commit that referenced this pull request Apr 23, 2025
* Output the public API only in the stack OpenAPI schema

* Fix comment

* Refactor OpenAPI conversion to define filters in a single place

(cherry picked from commit bd35837)
Anaethelion pushed a commit that referenced this pull request Apr 23, 2025
* Output the public API only in the stack OpenAPI schema

* Fix comment

* Refactor OpenAPI conversion to define filters in a single place

(cherry picked from commit bd35837)
Anaethelion added a commit that referenced this pull request Apr 23, 2025
* Output the public API only in the stack OpenAPI schema

* Fix comment

* Refactor OpenAPI conversion to define filters in a single place

(cherry picked from commit bd35837)

Co-authored-by: Sylvain Wallez <[email protected]>
Anaethelion added a commit that referenced this pull request Apr 23, 2025
* Output the public API only in the stack OpenAPI schema

* Fix comment

* Refactor OpenAPI conversion to define filters in a single place

(cherry picked from commit bd35837)

Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling visibility=private
3 participants