Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapped_pages front matter on docs/reference/index #2609

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

cotti
Copy link
Contributor

@cotti cotti commented Mar 29, 2025

Hello!

While I was working on making use of the front matter to show the user there's a previous version available, I've found this missing dash.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! BTW the failing tests in this PR aren't relevant to docs. I need to ask the devtools team about some other PRs so will include this one with my requests to them, and will take care of merging once we get around the tests.

@picandocodigo picandocodigo force-pushed the fix/mapped_pages_typo_fix branch from 81de08c to ca818c6 Compare April 1, 2025 08:01
@picandocodigo
Copy link
Member

Feel free to merge even with the failing tests, they're not related. I've rebased the PR with main, so most of the tests pass now. I'm working on fixing the opentelemetry test suite, they're failing because I haven't added the latest new APIs yet.

@marciw marciw merged commit e2d40b4 into main Apr 1, 2025
11 of 12 checks passed
@marciw marciw deleted the fix/mapped_pages_typo_fix branch April 1, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants