Skip to content

Unifying Elastic vector database and LLM functions for intelligent query Part 2 #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunilemanjee
Copy link
Contributor

Related to topic: https://github.com/orgs/elastic/projects/1446/views/1?filterQuery=llm+function&pane=issue&itemId=107821356&issue=elastic%7Csearch-labs-elastic-co%7C1535

I wrote part one here: https://www.elastic.co/search-labs/blog/llm-functions-elasticsearch-intelligent-query

This is part 2. Uses a different dataset (homes/properties instead of hotels) with the same intelligent query pattern identified in part 1. Additional part two leverages serverless and ships with a UI for search.

added additional logic for api key
Copy link

gitnotebooks bot commented Apr 24, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/453

"from IPython.display import Markdown, display\n",
"import requests, json\n",
"from getpass import getpass\n",
"from google.colab import userdata\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention at the top of the document that this notebook must run in a Google Colab environment?

@carlyrichmond
Copy link
Contributor

carlyrichmond commented Jul 18, 2025

@sunilemanjee I've spotted a couple of things:

  1. Can you change the example to use endpoint instead of Cloud ID? That has been the standard for a while.
  2. Can you also list the prerequisites need at the top of the notebook as well. It needs several different endpoints and keys, so having it all at the start with any useful setup guides (in addition to what you have in the accompanying blog) would be useful.
  3. Any change you can update the piece to at least 8.18? I get that 8.17 was the latest at the time of writing.
  4. Update the Google Collab link which is still pointing to the part 1 notebook.

@sunilemanjee
Copy link
Contributor Author

@carlyrichmond i'm slightly confused. There is no notebook in this demo or article

Can you change the example to use endpoint instead of Cloud ID? That has been the standard for a while.

  • Where is cloudID? the demo uses API key

Can you also list the prerequisites need at the top of the notebook as well. It needs several different endpoints and keys, so having it all at the start with any useful setup guides (in addition to what you have in the accompanying blog) would be useful.

  • I don't have a notebook for this article.

Any change you can update the piece to at least 8.18? I get that 8.17 was the latest at the time of writing.
Update the Google Collab link which is still pointing to the part 1 notebook.

  • again no notebook for this article

@carlyrichmond
Copy link
Contributor

@sunilemanjee I see in the commit history that this PR is picking up commits on the following notebook:

supporting-blog-content/unifying-elastic-vector-database-and-llms-for-intelligent-query/Unifying_Elastic_Vector_Database_and_LLMs_for_Intelligent_Query_Part_2.ipynb

Is that not correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants