Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequestConfigurationDescriptor copy constructor #136

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Nov 19, 2024

Add RequestConfigurationDescriptor copy constructor.

As well removes net6 TFMs.

@flobernd flobernd force-pushed the requestconfigurationdescriptor-copy-ctor branch from 73eeb82 to 0569ac9 Compare November 19, 2024 14:45
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a few

#if NET6_0_OR_GREATER

In the codebase but I am happy for these to remain anchored to 6.

LGTM!

@flobernd
Copy link
Member Author

#if NET6_0_OR_GREATER

Yes, we should probably just use #if NET like I did in this PR. I guess replacing these incrementally is fine 🙂

Thanks for approving.

@flobernd flobernd added v0.5.3 enhancement New feature or request labels Nov 19, 2024
@flobernd flobernd merged commit af894be into main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v0.5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants