Various cleanup, fixes and XML docs comments #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a varied bunch of cleanup initially started when replacing XML todos with meaningful documentation.
We've removed the concept of setting
ActivitySource
andMeter
names on our options. This is now confusing, and it's better to prefer the Otel native way to manage that. This also means a few other overloads that worked withparams string[]
can now be removed.Now that we accept a log file directory env var and when present, enable the file logger, some of the redundant code could be removed. We no longer need a default directory and only log if this is explicitly set.
Removes a few unused types.
Log messages were updated to reflect new type names. Some were removed and event IDs were also deduped.
Some classes that I don't expect us or consumers to extend are sealed.