Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanup, fixes and XML docs comments #64

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

stevejgordon
Copy link
Contributor

This is a varied bunch of cleanup initially started when replacing XML todos with meaningful documentation.

We've removed the concept of setting ActivitySource and Meter names on our options. This is now confusing, and it's better to prefer the Otel native way to manage that. This also means a few other overloads that worked with params string[] can now be removed.

Now that we accept a log file directory env var and when present, enable the file logger, some of the redundant code could be removed. We no longer need a default directory and only log if this is explicitly set.

Removes a few unused types.

Log messages were updated to reflect new type names. Some were removed and event IDs were also deduped.

Some classes that I don't expect us or consumers to extend are sealed.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevejgordon stevejgordon merged commit fd70175 into main Mar 25, 2024
4 checks passed
@stevejgordon stevejgordon deleted the alpha1-cleanup branch March 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants