Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move our AgentBuilder to IOpenTelemetryBuilder #47

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Mar 4, 2024

This is not yet released see open-telemetry/opentelemetry-dotnet#5265 for more background.

For now we include a temporary copy with hacks to call internal bits.

This allows AgentBuilder to be a native opentelemetry builder and we'd inherit all extension methods from the OpenTelemetry community

This is not yet released see open-telemetry/opentelemetry-dotnet#5265 for more background.

For now we include a temporary copy with hacks to call internal bits.

This allows AgentBuilder to be a native opentelemetry builder and we'd inherit all extension methods from the OpenTelemetry community
@Mpdreamz Mpdreamz requested a review from stevejgordon March 4, 2024 14:34
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Reviewed over Zoom

@Mpdreamz Mpdreamz merged commit f2f6f6c into main Mar 5, 2024
3 checks passed
@Mpdreamz Mpdreamz deleted the feature/move-to-iopentelemetrybuilder branch March 5, 2024 10:19
@Mpdreamz Mpdreamz added this to the 0.1.0 Alpha milestone Mar 6, 2024
@Mpdreamz Mpdreamz self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants