Remove Agent.Current, rely only on AgentBuilder" #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
added a commit
that referenced
this pull request
Mar 4, 2024
* Make FileLogger an ILogger implementation * fix boolean logic isenabled * add simple logging assertions * Update example to include activity source name * Update logging test so that agent is disposed before we validate logs * Return new list * ensure AgentBuilder.Agent disposes all * remove ElasticDiagnosticLoggingObserver so logging is no longer duplicated over all active loggers * Remove Agent.Current, rely only on AgentBuilder" (#46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of: #45
Removes additional logging related to static
Agent.Currentwhich we discussed to remove during EAH.