Refactor public API and align with 1.10 and 1.11 of the SDK #210
+3,116
−2,234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update and simplify XML doc comments. Add tests.
This is no longer needed as ingest handles this.
- Make not production ready processors internal. - Seal processors.
- Extensions to IHostApplicationBuilder - Extensions to IServiceCollection
stevejgordon
force-pushed
the
remove-global-override
branch
from
fe3dad1 to
c90d61d
Compare
|
The |
trentm
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a significant update from the previous code and includes a lot of refactorings as a result. In short, as the SDK since 1.10 includes an
OpenTelemetryBuilder, we can base many extension methods directly on the interface it implementsIOpenTelemetryBuilder.A significant change in this PR is removing the "magic" global override we used to replace
AddOpenTelemetrywith our behaviour. We no longer do this to avoid surprises and prefer an explicit small code change from consumers.We now also track the calls to the various builders to avoid bootstrapping components more than is required and log such circumstances.
We expect the auto instrumentation tests to fail for now as those need to be uncoupled from the SDK workflow.
Closes #164
Closes #175