Adding 8.18 and 8.18.0 details, master not bumped as it's on 9.0.0, current still 8.17 #3161
Conversation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
| @@ -1031,7 +1031,7 @@ contents: | |||
| prefix: en/ecs | |||
| # Please do not update current to 8.18 | |||
| current: 8.17 | |||
There was a problem hiding this comment.
@lcawl , @bmorelli25 : I have a question here... are we going to keep ECS current in 8.17 even after releasing 8.18? why do we have that comment to not update current to 8.18? And why we don't have current = stackcurrent?
There was a problem hiding this comment.
The ECS folks manage that book and just bumped it recently in #3157 it doesn't follow the same cadence as the other stack-versioned docs.
| :major-version-only: 9 | ||
| :ecs_version: 8.17 | ||
| :ecs_version: 8.18 |
There was a problem hiding this comment.
Same here @lcawl , @bmorelli25 .
Also I have left master as 9.0 and only changed the references to 8.17 to 8.18. Let me know if this looks all right.
There was a problem hiding this comment.
IMO you shouldn't need to touch master.asciidoc at all.
There was a problem hiding this comment.
But master has this...
prev-major-last: 8.17
Shouldn't that line be bumped to 8.18?
This needs review as I have some concerns due to:
Comments added in the code.